I see thanks Sanjay. When you see a bug in your area its generally a good practice to see holistically something similar you missed while feature development :).
On 17/04/13 12:41 PM, "Sanjay Tripathi" <sanjay.tripa...@citrix.com> wrote: >Nitin, >Sailaja is testing this feature and I think she covered all the possible >operations related to this feature in the Test cases she shared with the >community. > >--Sanjay > >> -----Original Message----- >> From: Nitin Mehta >> Sent: Wednesday, April 17, 2013 12:12 PM >> To: dev@cloudstack.apache.org; Sanjay Tripathi; Sateesh Chodapuneedi; >>Min >> Chen; Devdeep Singh >> Cc: cloudstack >> Subject: Re: Review Request: CLOUDSTACK-1966 Primary Storage Limits are >> not validated while deploying the VM >> >> Probably not a bad time to ask if we have put in this check in all the >> operations - can you please enlist it ? >> >> On 16/04/13 5:17 PM, "Sanjay Tripathi" <sanjay.tripa...@citrix.com> >>wrote: >> >> > >> >----------------------------------------------------------- >> >This is an automatically generated e-mail. To reply, visit: >> >https://reviews.apache.org/r/10541/ >> >----------------------------------------------------------- >> > >> >Review request for cloudstack, Devdeep Singh, Sateesh Chodapuneedi, and >> >Min Chen. >> > >> > >> >Description >> >------- >> > >> >CLOUDSTACK-1966 Primary Storage Limits are not validated while >> >deploying the VM. >> > >> > >> >This addresses bug CLOUDSTACK-1966. >> > >> > >> >Diffs >> >----- >> > >> > server/src/com/cloud/vm/UserVmManagerImpl.java d281e5b >> > >> >Diff: https://reviews.apache.org/r/10541/diff/ >> > >> > >> >Testing >> >------- >> > >> >Tests: >> >1. Create a user account. >> >2. Set the primary storage limit for this user account to 2GiB. >> >3. Log into the user account. >> >4. Deploy instance with template size > 2GiB 5. CloudStack displays the >> >appropriate error message. >> > >> > >> >Thanks, >> > >> >Sanjay Tripathi >> > >
