Likitha,

Firstly, That is a *quality* test that you've written. Well
documented, includes library methods where needed, and well-indented!

I've modified your test slightly to include it to be part of the
mvn+marvin run. The idea is that you'll include them to run against
the simulator/devcloud and tag it to run on that environment.

After I switched to your branch I did the following:
(after cherry-pick f8bbd88a42ab64bf10d0ca2681c246810a4d2be0 from maste)

1. build (with -Dsimulator)
2. deploydb (with deploydb-simulator)
3. jetty:run

Because you have a new API that my marvin install doesn't have I did a
sync.
$ sudo mvn -Pdeveloper,marvin.sync -Dendpoint=localhost -pl :cloud-marvin

And then the setup:
$ mvn -Pdeveloper,marvin.test -pl :cloud-marvin integration-test 
-Dmarvin.config=setup/dev/advanced.cfg

Finally the test run including your test:
~/workspace/cloudstack/incubator-cloudstack(branch:dedicate_public_ip_range_2*) 
?? mvn -Pdeveloper,marvin.test -pl :cloud-marvin integration-test 
-Dmarvin.config=setup/dev/advanced.cfg
[INFO] Scanning for projects...
[INFO]                                                                         
[INFO] ------------------------------------------------------------------------
[INFO] Building Apache CloudStack marvin 4.2.0-SNAPSHOT
[INFO] ------------------------------------------------------------------------
[INFO] 
[INFO] --- exec-maven-plugin:1.2.1:exec (generate-sources) @ cloud-marvin ---
[INFO] 
[INFO] --- maven-remote-resources-plugin:1.3:process (default) @ cloud-marvin 
---
[INFO] 
[INFO] --- maven-site-plugin:3.1:attach-descriptor (attach-descriptor) @ 
cloud-marvin ---
[INFO] 
[INFO] --- exec-maven-plugin:1.2.1:exec (integration-test) @ cloud-marvin ---
Test to create disk offering ... ok
Test to update existing disk offering ... ok
Test to delete disk offering ... ok
Test public IP range dedication ... ok
Test advanced zone virtual router ... ok
Test Deploy Virtual Machine ... ok

----------------------------------------------------------------------
Ran 6 tests in 30.895s

OK
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 36.978s
[INFO] Finished at: Wed Apr 10 17:04:47 GMT+05:30 2013
[INFO] Final Memory: 18M/81M
[INFO] ------------------------------------------------------------------------

+1 on the merge :)

Thanks,

-- 
Prasanna.,

On Tue, Apr 09, 2013 at 12:35:33PM -0700, Chiradeep Vittal wrote:
> Can you also run "Integrated Simulator+Marvin test" from
> https://cwiki.apache.org/confluence/x/PgvMAQ
> 
> On 4/9/13 10:23 AM, "Likitha Shetty" <likitha.she...@citrix.com> wrote:
> 
> >Hi all,
> >
> >I would like to merge the feature Dedicate Public IP ranges to master.
> >
> >Jira ticket - https://issues.apache.org/jira/browse/CLOUDSTACK-704
> >Proposal discussion -
> >http://mail-archives.apache.org/mod_mbox/incubator-cloudstack-users/201303
> >.mbox/%3C64FB1554ABC9B44FAA773FBD6CB889C2010D9C03119B%40BANPMAILBOX01.citr
> >ite.net%3E 
> >FS - 
> >https://cwiki.apache.org/confluence/display/CLOUDSTACK/FS-+Dedicate+Public
> >+IP+Addresses+per+tenant
> >Branch - dedicate_public_ip_range_2
> >Unit tests -  Unit tests for the new API's can be found at
> >cloudstack/server/test/com/cloud/configuration/ConfigurationManagerTest.ja
> >va
> >Integration tests - Python tests can be found be found at
> >test/integration/component/test_public_ip_range.py
> >Rebased the branch with master - Commit id:
> >d5d167cb97b95f5622c0e34fe4546642484016f6
> >RAT report - Attached
> >Patch is available at - https://reviews.apache.org/r/10377/
> >
> >Thanks,
> >Likitha

Reply via email to