----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9541/#review18496 -----------------------------------------------------------
Commit 18695276f79a4cf90279f6ff25ebc7c66b6a9c49 in branch refs/heads/master from Nitin Mehta <nitin.me...@citrix.com> [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=1869527 ] CLOUDSTACK-1156: Limit Primary and Secondary storage for domain/accounts Addition of two new resource types i.e. Primary and Secondary storage space in the existing pool of resource types. Added methods to set the limits on these resources using updateResourceLimit API command and to get a count using updateResourceCount. Also added calls in the Templates, Volumes, Snapshots life cycle to check these limits and to increment/decrement the new resource types Resource Name :: Resource type number Primary Storage 10 Secondary Storage 11 Also added jUnit Tests for the same. Reviewed by : nitin mehta<nitin.me...@citrix.com> - ASF Subversion and Git Services On March 28, 2013, 8:36 a.m., Sanjay Tripathi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/9541/ > ----------------------------------------------------------- > > (Updated March 28, 2013, 8:36 a.m.) > > > Review request for cloudstack, Devdeep Singh, Nitin Mehta, Sateesh > Chodapuneedi, mice xia, and Min Chen. > > > Description > ------- > > CLOUDSTACK-1156: Limit Primary and Secondary storage for domain/accounts > > Addition of two new resource types i.e. Primary and Secondary storage > space in the existing pool of > resource types. > Added methods to set the limits on these resources using > updateResourceLimit > API command and to get a count using updateResourceCount. Also added > calls in the > Templates, Volumes, Snapshots life cycle to check these limits and to > increment/decrement the new > resource types > > Resource Name :: Resource type number > Primary Storage 10 > Secondary Storage 11 > > Also added jUnit Tests for the same. > > > This addresses bug CLOUDSTACK-1156. > > > Diffs > ----- > > api/src/com/cloud/configuration/Resource.java 7614c8a > api/src/com/cloud/storage/VolumeApiService.java 8517988 > > api/src/org/apache/cloudstack/api/command/user/resource/UpdateResourceCountCmd.java > f6d3a98 > > api/src/org/apache/cloudstack/api/command/user/resource/UpdateResourceLimitCmd.java > 0039f62 > api/src/org/apache/cloudstack/api/command/user/volume/ResizeVolumeCmd.java > 955727a > api/src/org/apache/cloudstack/api/response/AccountResponse.java 9a98a35 > api/src/org/apache/cloudstack/api/response/ResourceCountResponse.java > a7fbbf2 > api/src/org/apache/cloudstack/api/response/ResourceLimitResponse.java > b444e7a > > plugins/hypervisors/baremetal/src/com/cloud/baremetal/manager/BareMetalTemplateAdapter.java > 33725f6 > server/src/com/cloud/alert/AlertManagerImpl.java a45482f > server/src/com/cloud/api/ApiResponseHelper.java f33601f > server/src/com/cloud/api/query/dao/AccountJoinDaoImpl.java 898bafc > server/src/com/cloud/api/query/vo/AccountJoinVO.java cd7231c > server/src/com/cloud/configuration/Config.java 1a57a64 > server/src/com/cloud/resourcelimit/ResourceLimitManagerImpl.java 23c0796 > server/src/com/cloud/storage/VolumeManager.java af3cbbf > server/src/com/cloud/storage/VolumeManagerImpl.java 737ed0a > server/src/com/cloud/storage/dao/SnapshotDao.java 0e378a7 > server/src/com/cloud/storage/dao/SnapshotDaoImpl.java 825b6d5 > server/src/com/cloud/storage/dao/VolumeDao.java d7a2667 > server/src/com/cloud/storage/dao/VolumeDaoImpl.java 40ed875 > server/src/com/cloud/storage/download/DownloadListener.java d4c20cf > server/src/com/cloud/storage/download/DownloadMonitorImpl.java 0bc89e3 > server/src/com/cloud/storage/snapshot/SnapshotManagerImpl.java bacca01 > server/src/com/cloud/template/HypervisorTemplateAdapter.java 1426421 > server/src/com/cloud/template/TemplateManagerImpl.java d843dbc > server/src/com/cloud/vm/UserVmManagerImpl.java 82a69bd > server/test/com/cloud/resourcelimit/ResourceLimitManagerImplTest.java > d311ad3 > server/test/com/cloud/vpc/MockResourceLimitManagerImpl.java b9fc861 > setup/db/db/schema-40to410.sql 60ad025 > setup/db/db/schema-410to420.sql 9eed0a6 > utils/src/com/cloud/utils/UriUtils.java a8b5ccb > > Diff: https://reviews.apache.org/r/9541/diff/ > > > Testing > ------- > > Tested life cycle of templates, volumes, snapshots, vm on my local CloudStack > setup. > > > Thanks, > > Sanjay Tripathi > >