Appreciate the promptness! > I can, but next time can we *please* either send out an "[ACS41][Patch > Request]" email OR add me to the review?
Will do next time, thanks for the guidance! > -----Original Message----- > From: Chip Childers [mailto:chip.child...@sungard.com] > Sent: Thursday, March 21, 2013 10:23 PM > To: dev@cloudstack.apache.org > Cc: cloudstack-...@incubator.apache.org; Sudha Ponnaganti; Sowmya > Krishnan > Subject: Re: Commiting reviews 10017 (4.1) & 10058 (master) for > CLOUDSTACK-1537 > > On Thu, Mar 21, 2013 at 04:49:06PM +0000, Vijay Venkatachalam wrote: > > Reminder! > > > > Can someone commit the patch from review 10058 in master? > > > > Chip, > > Can you commit the review 10017 in 4.1, this cannot be cherry picked > from master because of the health check commit that went in master. > > > > Both the reviews has already been marked for Ship! > > I can, but next time can we *please* either send out an "[ACS41][Patch > Request]" email OR add me to the review? > > > > > > > Thanks, > > Vijay V. > > > -----Original Message----- > > > From: Devdeep Singh [mailto:nore...@reviews.apache.org] On Behalf Of > > > Devdeep Singh > > > Sent: Thursday, March 21, 2013 7:25 PM > > > To: Rajesh Battala; Devdeep Singh > > > Cc: cloudstack; Vijay Venkatachalam > > > Subject: Re: Review Request: Summary: Fix for CLOUDSTACK-1537 - > > > Restart network with clean up set to true causes Autoscaled LB rule > > > to get mangled and unusable > > > > > > > > > ----------------------------------------------------------- > > > This is an automatically generated e-mail. To reply, visit: > > > https://reviews.apache.org/r/10058/#review18205 > > > ----------------------------------------------------------- > > > > > > Ship it! > > > > > > > > > Looks good. A committer needs to commit these changes. > > > > > > - Devdeep Singh > > > > > > > > > On March 21, 2013, 11:19 a.m., Vijay Venkatachalam wrote: > > > > > > > > ----------------------------------------------------------- > > > > This is an automatically generated e-mail. To reply, visit: > > > > https://reviews.apache.org/r/10058/ > > > > ----------------------------------------------------------- > > > > > > > > (Updated March 21, 2013, 11:19 a.m.) > > > > > > > > > > > > Review request for cloudstack, Devdeep Singh and Rajesh Battala. > > > > > > > > > > > > Description > > > > ------- > > > > > > > > > > > > Tested Reviewed and Marked for Ship already in 4.1 branch. > > > https://reviews.apache.org/r/10017/ > > > > > > > > The patch wont apply to master branch so submitting a new patch for it. > > > > > > > > Bug Title: Restart network with clean up set to true causes > > > > Autoscaled LB > > > rule to get mangled and unusable > > > > > > > > AutoScale LB information was not packaged for restart of network > > > > case to > > > Resource Layer. This caused the undesired outcome and it is fixed now. > > > NetWorkManagerImpl was doing the cleanup of the LBRules during > > > restart, after the fix; NetWorkManagerImpl will only act as a > > > trigger, the actual job related to LB Rules (for ex. remove/revoke) > > > will be handled by LBRules Manager (which should have been the > > > actual implementation, so moved code around). > > > > > > > > Also, NetScaler resource is simplified to handle > > > create/enable/disable/restart in one code path. > > > > > > > > > > > > This addresses bug CLOUDSTACK-1537. > > > > > > > > > > > > Diffs > > > > ----- > > > > > > > > api/src/com/cloud/network/lb/LoadBalancingRule.java 84526c5 > > > > plugins/network- > > > > elements/netscaler/src/com/cloud/network/resource/NetscalerResource. > > > ja > > > va 4eb0ce2 > > > > server/src/com/cloud/network/NetworkManagerImpl.java 591910b > > > > server/src/com/cloud/network/lb/LoadBalancingRulesManager.java > > > da19f86 > > > > > > > > > server/src/com/cloud/network/lb/LoadBalancingRulesManagerImpl.java > > > a06cbc5 > > > > > > > > Diff: https://reviews.apache.org/r/10058/diff/ > > > > > > > > > > > > Testing > > > > ------- > > > > > > > > Tested Reviewed and Marked for Ship already in 4.1 branch. > > > https://reviews.apache.org/r/10017/ > > > > > > > > > > > > Thanks, > > > > > > > > Vijay Venkatachalam > > > > > > > > > >
