----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10058/#review18218 -----------------------------------------------------------
Ship it! Ship It! - Chip Childers On March 21, 2013, 11:19 a.m., Vijay Venkatachalam wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/10058/ > ----------------------------------------------------------- > > (Updated March 21, 2013, 11:19 a.m.) > > > Review request for cloudstack, Devdeep Singh and Rajesh Battala. > > > Description > ------- > > > Tested Reviewed and Marked for Ship already in 4.1 branch. > https://reviews.apache.org/r/10017/ > > The patch wont apply to master branch so submitting a new patch for it. > > Bug Title: Restart network with clean up set to true causes Autoscaled LB > rule to get mangled and unusable > > AutoScale LB information was not packaged for restart of network case to > Resource Layer. This caused the undesired outcome and it is fixed now. > NetWorkManagerImpl was doing the cleanup of the LBRules during restart, after > the fix; NetWorkManagerImpl will only act as a trigger, the actual job > related to LB Rules (for ex. remove/revoke) will be handled by LBRules > Manager (which should have been the actual implementation, so moved code > around). > > Also, NetScaler resource is simplified to handle > create/enable/disable/restart in one code path. > > > This addresses bug CLOUDSTACK-1537. > > > Diffs > ----- > > api/src/com/cloud/network/lb/LoadBalancingRule.java 84526c5 > > plugins/network-elements/netscaler/src/com/cloud/network/resource/NetscalerResource.java > 4eb0ce2 > server/src/com/cloud/network/NetworkManagerImpl.java 591910b > server/src/com/cloud/network/lb/LoadBalancingRulesManager.java da19f86 > server/src/com/cloud/network/lb/LoadBalancingRulesManagerImpl.java a06cbc5 > > Diff: https://reviews.apache.org/r/10058/diff/ > > > Testing > ------- > > Tested Reviewed and Marked for Ship already in 4.1 branch. > https://reviews.apache.org/r/10017/ > > > Thanks, > > Vijay Venkatachalam > >
