----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10060/#review18204 -----------------------------------------------------------
patches/systemvm/debian/config/etc/init.d/cloud-early-config <https://reviews.apache.org/r/10060/#comment38418> What is being waited for? If we just need a buffer between deleting the default router and adding the new one, this is fine. But if it's a timing issue where we are waiting on a network device, I'd rather have a while loop that verifies what we are waiting on before continuing. We recently added something similar to vpc_ipassoc.sh: # need to wait for eth device to appear before configuring it timer=0 while ! `grep -q $ethDev /proc/net/dev` ; do logger -t cloud "$(basename $0):Waiting for interface $ethDev to appear, $timer seconds" sleep 1; if [ $timer -gt 15 ]; then logger -t cloud "$(basename $0):interface $ethDev never appeared" break fi timer=$[timer + 1] done - Marcus Sorensen On March 21, 2013, 12:44 p.m., Jayapal Reddy wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/10060/ > ----------------------------------------------------------- > > (Updated March 21, 2013, 12:44 p.m.) > > > Review request for cloudstack, Anthony Urso, Abhinandan Prateek, edison su, > Rohit Yadav, and Marcus Sorensen. > > > Description > ------- > > Added sleep in cloud-early-config before adding route > > > This addresses bug CLOUDSTACK-1565. > > > Diffs > ----- > > patches/systemvm/debian/config/etc/init.d/cloud-early-config 1f0b9a7 > > Diff: https://reviews.apache.org/r/10060/diff/ > > > Testing > ------- > > Tested for ssvm, cpvm and router. Default route added properly > > > Thanks, > > Jayapal Reddy > >
