Hi Alwin, Thanks for the careful review and for raising these points.
Regarding `mcp-server/`, my understanding is that it is part of the overall Apache Cloudberry source release, so it is covered by the top-level `LICENSE` and `NOTICE` in the release root. The source files in that directory also carry the standard ASF Apache license header. For the wheel reference, I confirmed that the staged source does not include any pre-built `.whl` or other binary artifact. The README only mentions a wheel filename as an example of local/separate installation, rather than bundling a binary inside the source release. For the `DB_USER` example, I agree that a generic placeholder would be better. If someone can help with this, we can include this small improvement in a future release. Thanks again for the detailed review and helpful suggestions. Best, Dianjin Wang On Fri, Mar 6, 2026 at 4:08 PM Alwin Tang <[email protected]> wrote: > > Many thanks to Dianjing and the team for putting together this RC. > > I have reviewed the staged artifacts and git tags. I am casting a 0 > (abstain) for now, as I have a few open questions for the new added > "mcp-server/" I'd like clarified before I can move to a binding +1. > > 1. **Missing LICENSE and NOTICE in mcp-server/** > The subdirectory does not appear to contain its own LICENSE or NOTICE > file. Given that the inner Python package (cbmcp) is independently > installable and the README documents standalone pip/uvx installation, we > may want to confirm these are covered by the top-level files or add > dedicated ones to mcp-server/. > > 2. **Pre-built .whl referenced by filename in README** > The Claude Desktop integration docs reference > `cbmcp-0.1.0-py3-none-any.whl` by exact path. We may want to confirm no > compiled wheel or binary artifact is bundled in the staged source tarball > to avoid a potential policy violation. > > 3. **Hardcoded personal username in README** > The Claude Desktop config example contains hardcoded personal username > for "DB_USER". It is best practice to be replaced with a generic > placeholder. > > Happy to re-vote once these are addressed or clarified. > > Warmly, > + Alwin > > > Dianjin Wang <[email protected]> 于2026年3月5日周四 11:19写道： > > > my +1 (binding). > > > > [x] Download links are valid and accessible. > > [x] GPG signature is valid for the release artifact using the KEYS file. > > [x] SHA512 checksums are correct and verified. > > [x] Source release artifact filename includes "incubating". > > [x] LICENSE, NOTICE, and DISCLAIMER files exist and are accurate. > > [x] No unexpected binary files in the source release. > > [x] All source files have appropriate ASF headers (excluding generated > > files and legacy files). > > [x] Build completes successfully from source with clear instructions. > > - Test under Rocky 8/9 + Ubuntu 22.04 following the guide. > > > > > > Best, > > Dianjin Wang > > > > On Thu, Mar 5, 2026 at 9:39 AM Max Yang <[email protected]> wrote: > > > > > > +1 (binding). > > > > > > Best regards, Max Yang > > > > > > > > > On Wed, Mar 4, 2026 at 5:47 PM Dianjin Wang <[email protected]> > > wrote: > > > > > > > Hi all, > > > > > > > > I would like to call a VOTE to release Apache Cloudberry (Incubating) > > > > 2.1.0-rc1. > > > > > > > > ## Release Candidate Artifacts > > > > > > > > This vote covers the source release artifacts for Apache Cloudberry > > > > (Incubating) 2.1.0-rc1, including the main Cloudberry project and the > > > > two components cloudberry-backup and cloudberry-pxf. > > > > > > > > Staged release artifacts: > > > > > > > > > > https://dist.apache.org/repos/dist/dev/incubator/cloudberry/2.1.0-incubating-rc1/ > > > > > > > > Git tag & commit for the release: > > > > - cloudberry > > > > https://github.com/apache/cloudberry/tree/2.1.0-incubating-rc1 > > > > > > > > > > https://github.com/apache/cloudberry/commit/bdf90c5518f916f5dfea335c1cd83724e0ebe9e2 > > > > > > > > - cloudberry-backup > > > > https://github.com/apache/cloudberry-backup/tree/2.1.0-incubating-rc1 > > > > > > > > > > https://github.com/apache/cloudberry-backup/commit/c909fbe94672f4a4536f4afd25b6aaec69ed2464 > > > > > > > > - cloudberry-pxf > > > > https://github.com/apache/cloudberry-pxf/tree/2.1.0-incubating-rc1 > > > > > > > > > > https://github.com/apache/cloudberry-pxf/commit/59dcedd21e8867dcc133df6527b99b4fa4d7b977 > > > > > > > > KEYS file: > > > > https://downloads.apache.org/incubator/cloudberry/KEYS > > > > > > > > GPG signature key: 9A36AA272348A207E193A49C500708B75754FB7C > > > > > > > > The GPG user ID(s): Dianjin Wang <[email protected]> > > > > > > > > ## How to Vote > > > > > > > > Please review the release and cast your vote below. If you are a PPMC > > > > member, please indicate whether your vote is binding. Also, that would > > > > be better to list the items you checked in your reply - it shows what > > > > you vote for. > > > > > > > > [ ] +1 Approve the release > > > > [ ] 0 No opinion > > > > [ ] -1 Disapprove (please explain why) > > > > > > > > The vote is open for at least 72 hours and will close no earlier than > > > > March 8, 2026, at 08:00 UTC. > > > > > > > > ## Checklist for reference: > > > > > > > > [ ] Download links are valid and accessible. > > > > [ ] GPG signature is valid for the release artifact using the KEYS > > file. > > > > [ ] SHA512 checksums are correct and verified. > > > > [ ] Source release artifact filename includes "incubating". > > > > [ ] LICENSE, NOTICE, and DISCLAIMER files exist and are accurate. > > > > [ ] No unexpected binary files in the source release. > > > > [ ] All source files have appropriate ASF headers (excluding generated > > > > files and legacy files). > > > > [ ] Build completes successfully from source with clear instructions. > > > > > > > > More detailed checklist, please refer to: > > > > https://github.com/apache/cloudberry/wiki/Source-Release-Checklist > > > > > > > > Build/Install guides (for reference): > > > > - cloudberry: > > > > > > https://cloudberry.apache.org/docs/deployment/quick-build#for-apache-cloudberry-210 > > > > - cloudberry-pxf: > > > > > > > > > > https://github.com/apache/cloudberry-pxf/blob/2.1.0-incubating-rc1/README.md > > > > - cloudberry-backup: > > > > > > > > > > https://github.com/apache/cloudberry-backup/blob/2.1.0-incubating-rc1/README.md > > > > > > > > ## GPG Signature and SHA512 checksums Verification Instructions > > > > > > > > Please refer to our step-by-step guide: > > > > https://cloudberry.apache.org/releases/#verifying-releases > > > > > > > > ## About Convenience Binaries > > > > > > > > After this source release vote passes and the release is published, we > > > > plan to provide optional convenience binary packages via GitHub > > > > Releases for easier testing. These binaries are not part of this vote > > > > and are not ASF release artifacts. > > > > > > > > Thanks for reviewing and voting! > > > > > > > > > > > > Best, > > > > Dianjin Wang > > > > > > > > --------------------------------------------------------------------- > > > > To unsubscribe, e-mail: [email protected] > > > > For additional commands, e-mail: [email protected] > > > > > > > > > > > > --------------------------------------------------------------------- > > To unsubscribe, e-mail: [email protected] > > For additional commands, e-mail: [email protected] > > > > --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
