andi-huber commented on code in PR #2465:
URL: https://github.com/apache/causeway/pull/2465#discussion_r1626259525
##########
viewers/wicket/model/src/main/java/org/apache/causeway/viewer/wicket/model/models/ScalarParameterModel.java:
##########
@@ -58,8 +68,80 @@ private ScalarParameterModel(
}
@Override
- public String validate(final ManagedObject proposedValue) {
- return
getParameterNegotiationModel().getObservableParamValidation(getParameterIndex()).getValue();
+ public String validate(final ManagedObject proposedArg) {
+
+ val value =
getParameterNegotiationModel().getObservableParamValidation(getParameterIndex()).getValue();
+ if (value != null) {
+ return null;
Review Comment:
Is this logic flipped?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@causeway.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
