I would prefer we kept the old methods in place without deprecation. * I (and I assume others) learn about what I can do with JMX by using JConsole and browsing visually, and find it helpful to be able to look at a table and understand what I can do with it. Approaching it the other way isn't particularly intuitive to me, so from a user perspective, it's less friendly to at least a subset of our users.
* Unless I misunderstand the work involved, I think we're only talking about calling another method. The overhead on our side would be trivial in that case. Deprecation of anything is disruptive, and the gain sounds trivial at best. I don't think we've deprecated or removed anything that mentions "column family" or "cf" even though that hasn't been our user-facing terminology in close to a decade. Please correct me if I'm wrong on any of this. Thanks, Jon On Thu, Aug 1, 2024 at 3:03 AM Štefan Miklošovič <smikloso...@apache.org> wrote: > We are refactoring the snapshotting subsystem (CASSANDRA-18111) by > consolidating all snapshot logic in Cassandra code into a dedicated > SnapshotManager class where everything is centralized and dandy. > > The current state of snapshotting code is that over the years it became > scattered all over the place, hard to get the whole picture, hard to > maintain ... probable / possible concurrency issues etc. By doing 18111 we > will also save some disk IO. > > While doing so, we are indeed keeping everything functionally-wise as it > was before etc. but we think that the introduction of a dedicated > SnapshotManagerMBean (like this (1)) would be a good idea. We would keep > stuff in StorageServiceMBean / CFS there, it would just call > SnapshotManager methods and we would deprecate StorageServiceMBean methods. > > Since the introduction of SnapshotManagerMBean introduces a public-facing > API, I want to run this through ML to increase the awareness and get > approval for doing so. > > Does this make sense to people? > > Regards > > (1) > https://github.com/pauloricardomg/cassandra/blob/CASSANDRA-18111-review-2/src/java/org/apache/cassandra/service/snapshot/SnapshotManagerMBean.java > > >
