Hi, Would someone be able to review the trunk patch for https://issues.apache.org/jira/browse/CASSANDRA-18750? I'm fighting CircleCI to try and get anything to pass (everything fails with "Concurrency limit"), but builds and tests work locally (via "ant test" and the docker "run-tests.sh").
Cheers, Derek On Tue, Aug 15, 2023 at 8:13 AM Derek Chen-Becker <de...@chen-becker.org> wrote: > Thanks, I thought I had updated against trunk but apparently missed it. > It's working now. > > On Tue, Aug 15, 2023 at 7:27 AM Brandon Williams <dri...@gmail.com> wrote: > >> On Tue, Aug 15, 2023 at 8:13 AM Derek Chen-Becker <de...@chen-becker.org> >> wrote: >> > >> > Also, I noticed that the instructions on >> https://cassandra.apache.org/_/development/how_to_commit.html mention >> "ant jar check" as a recommended step, but there's not "check" target. Does >> it mean "checkstyle"? >> >> It exists in the cassandra-5.0 and trunk branches after CASSANDRA-18618 >> > > > -- > +---------------------------------------------------------------+ > | Derek Chen-Becker | > | GPG Key available at https://keybase.io/dchenbecker and | > | https://pgp.mit.edu/pks/lookup?search=derek%40chen-becker.org | > | Fngrprnt: EB8A 6480 F0A3 C8EB C1E7 7F42 AFC5 AFEE 96E4 6ACC | > +---------------------------------------------------------------+ > > -- +---------------------------------------------------------------+ | Derek Chen-Becker | | GPG Key available at https://keybase.io/dchenbecker and | | https://pgp.mit.edu/pks/lookup?search=derek%40chen-becker.org | | Fngrprnt: EB8A 6480 F0A3 C8EB C1E7 7F42 AFC5 AFEE 96E4 6ACC | +---------------------------------------------------------------+
