It's always seemed a little odd to me that we drop all the "read old format" code given how little maintenance that code takes over time. The ability to have a C* node read older format SSTables into perpetuity *seems* like a pretty compelling usability feature to me (for some of the reasons mentioned in this thread).
So personally, -1 to removing the code for 3.0, and generally think we should reconsider how long we maintain support specifically for reading older format files as we move forward given this is long-lived infra software. Probably pain-points I'm not thinking of here, but worth a deeper discussion IMO. On Tue, Mar 14, 2023, at 12:02 PM, Brandon Williams wrote: > On Mon, Mar 13, 2023 at 5:54 PM Mick Semb Wever <m...@apache.org> wrote: > > > Personally I am not in favour of keeping, or recommending users use, > > code we don't test. > > How much effort would it be to have some simple smoke tests? I think > we should make sure nothing gets indirectly broken if we're going to > keep it around. >
