What Benedict says is that the commits into cassandra/cep-15-accord and > cassandra-accord/trunk branch have all been vetted by at least two > committers already. Each authored by a Cassandra committer and then > reviewed by a Cassandra committer. That *is* our bar for merging into > Cassandra trunk. >
Yes yes. But we do catch things late, and the eyes on a merge would have a different PoV than original reviews, and that can be helpful. And yes, we can also review things post-commit if we like. I'm not saying it has to be done, or that our rules enforce it, just that I think it would be helpful to offer the invite for more eyeballs (and provide the hygiene in jira). Looking through the cep-15-accord branch there's >10 ninja-fixes. Won't these get cleaned up? And if so, shouldn't changes be open to another review round? It just seems like a more congenial manner to collaborate 🤷🏻♀️ And maybe no one is interested in such a second pass pre-merge review. idk.
