I should add that "no-checkstyle" will turn off whole checkstyle for good. Not 
unused imports only. This is same logic as for javadocs - "no-javadoc" flag

________________________________________
From: Miklosovic, Stefan
Sent: Thursday, September 22, 2022 20:19
To: dev@cassandra.apache.org
Subject: Checkstyle will be updated to fail Ant build when unused imports are 
present in the code

Hi list,

I would like to highlight this ticket (1). I hope we manage to merge it in the 
foreseeable future. It will be in cassanra-4.1 and in trunk. Once in, by 
default, if there are unused imports in Java code, ant build will fail.

There will be a workaround by which you can skip failing when imports are 
unused - by "-Dno-checkstyle=true" flag. It is there for local development when 
you are just not interested in having the code clean on imports. The check will 
be present for tests as well (same flag).

This should save us from going through the source code on reviews and writing 
these "nit: unused imports" and all imports will be used from now.

Please let me know if there are any concerns and if this workflow is fine for 
you.

​<https://issues.apache.org/jira/browse/CASSANDRA-17876>(1) 
https://issues.apache.org/jira/browse/CASSANDRA-17876

Regards,

Stefan Miklosovic

Reply via email to