So, I went through all pull requests we have on GitHub manually (yes, I did that, never more!) and out of ~550 PRs I managed to reduce it to 188 so I closed around 400 PRs.
All remaining PRs are of this nature: 1) Every PR has a name of "CASSANDRA-XYZ - description" or there is a ticket number in it so it is searchable on GH. 2) PR which does not have a ticket is labeled "missing-ticket" 3) PRs which are related to docs are labeled as docs, PRs related to tests are labeled as "tests" 4) There are combinations of 2) and 3) so we can have, for example, only PRs which are missing ticket and they are related to docs. docs PRs: https://github.com/apache/cassandra/pulls?q=is%3Apr+is%3Aopen+label%3Adocs missing tickets PRs: https://github.com/apache/cassandra/pulls?q=is%3Apr+is%3Aopen+label%3Amissing-ticket tests PRs: https://github.com/apache/cassandra/labels/tests Out of 188 PRs open, there is 35 documentation related PRs and 54 PRs are missing their tickets. What I would like to do now is to go to documentation guys and it would be awesome if they can go through documentation PRs and resolve all of them, preferably in one big PRs to solve it all. It does not make a lot of sense to deal with each minor thing separately. Then we might deal with the PRs which are solely missing tickets separately. How does this sound to you? Regards, Stefan On Wed, 16 Mar 2022 at 15:02, Jeff Jirsa <jji...@gmail.com> wrote: > > An easier fix here is just to put a close action into the commit message: > > Closes #nnn > > e.g. > https://github.com/apache/cassandra/commit/ad249424814836bd00f47931258ad58bfefb24fd > / https://github.com/apache/cassandra/pull/1046 > > On Wed, Mar 16, 2022 at 5:40 AM Josh McKenzie <jmcken...@apache.org> wrote: >> >> I think the fact that they pile up is because our merge strategy means we >> don't actually merge using the PR's we use for review so there's nothing >> codified in the workflow to close them out when a ticket's done. >> >> An easy fix would be to change our merge strategy and use the merge button >> on PR's to merge things in so they auto-close. :) >> >> (/grinding my axe) >> >> On Wed, Mar 16, 2022, at 7:27 AM, Paulo Motta wrote: >> >> Thanks for doing this Stefan. >> >> The fact that PRs are abandoned and piling up on github demonstrates a >> hygiene problem and creates a bad user experience to newcomers which are >> accustomed to the Github workflow. I'm supportive of any initiative to >> improve this >> >> I think starting labelling PRs manually and then looking into ways to >> automate this would be a good improvement from the status quo. >> >>
