+1 for keeping doc changes out. Definitely no good reason for keeping them.
On Fri, Apr 10, 2020 at 1:39 PM Jon Haddad <j...@jonhaddad.com> wrote: > > In a conversation with Mick we discussed keeping doc changes out as well. > Anyone object to eliding documentation changes from CHANGES.txt? > > > > > > > On Thu, Apr 9, 2020 at 1:07 AM Benjamin Lerer <benjamin.le...@datastax.com> > wrote: > > > +1 > > > > > > > > On Thu, Apr 9, 2020 at 9:28 AM Eduard Tudenhoefner < > > eduard.tudenhoef...@datastax.com> wrote: > > > > > updated docs in https://github.com/apache/cassandra/pull/528 > > > > > > On Wed, Apr 8, 2020 at 11:39 PM Jordan West <jorda...@gmail.com> wrote: > > > > > > > +1 (nb) to the change and +1 (nb) to updating the docs to reflect this. > > > > > > > > Jordan > > > > > > > > On Wed, Apr 8, 2020 at 11:30 AM <a.penya.gar...@gmail.com> wrote: > > > > > > > > > +1 > > > > > > > > > > > El 8 abr 2020, a las 19:05, e.dimitr...@gmail.com escribió: > > > > > > > > > > > > +1 > > > > > > > > > > > > Sent from my iPhone > > > > > > > > > > > >> On 8 Apr 2020, at 13:50, Joshua McKenzie <jmcken...@apache.org> > > > > wrote: > > > > > >> > > > > > >> +1 > > > > > >> > > > > > >>>> On Wed, Apr 8, 2020 at 12:26 PM Sam Tunnicliffe <s...@beobal.com > > > > > > > > wrote: > > > > > >>> > > > > > >>> +1 > > > > > >>> > > > > > >>>>> On 8 Apr 2020, at 15:08, Mick Semb Wever <m...@apache.org> > > wrote: > > > > > >>>> > > > > > >>>> Can we agree on keeping such test changes out of CHANGES.txt ? > > > > > >>>> > > > > > >>>> We already don't put entries into CHANGES.txt if it is not a > > > change > > > > > >>>> from any previous release. > > > > > >>>> > > > > > >>>> There was some discussion before¹ about this, and the problem > > that > > > > > >>>> being selective meant what ended up there being arbitrary. I > > think > > > > > >>>> this can be solved with an easy rule of thumb that if it only > > > > touches > > > > > >>>> *Test.java classes, or it is only about fixing a test, then it > > > > > >>>> shouldn't be in CHANGES.txt. That means if the patch does touch > > > any > > > > > >>>> runtime code then you do still need to add an entry to > > > CHANGES.txt. > > > > > >>>> This avoids the whole "arbitrary" problem, and maintains > > > > CHANGES.txt > > > > > >>>> as user-facing formatted text to be searched through. > > > > > >>>> > > > > > >>>> If there's agreement I can commit to going through 4.0 changes > > and > > > > > >>>> removing those that never touched runtime code. > > > > > >>>> > > > > > >>>> regards, > > > > > >>>> Mick > > > > > >>>> > > > > > >>>> ¹) > > > > > >>> > > > > > > > > > > > > > > https://lists.apache.org/thread.html/a94946887081d8a408dd5cd01a203664f4d0197df713f0c63364a811%40%3Cdev.cassandra.apache.org%3E > > > > > >>>> > > > > > >>>> > > > > --------------------------------------------------------------------- > > > > > >>>> To unsubscribe, e-mail: dev-unsubscr...@cassandra.apache.org > > > > > >>>> For additional commands, e-mail: dev-h...@cassandra.apache.org > > > > > >>>> > > > > > >>> > > > > > >>> > > > > > >>> > > > --------------------------------------------------------------------- > > > > > >>> To unsubscribe, e-mail: dev-unsubscr...@cassandra.apache.org > > > > > >>> For additional commands, e-mail: dev-h...@cassandra.apache.org > > > > > >>> > > > > > >>> > > > > > > > > > > > > > > --------------------------------------------------------------------- > > > > > > To unsubscribe, e-mail: dev-unsubscr...@cassandra.apache.org > > > > > > For additional commands, e-mail: dev-h...@cassandra.apache.org > > > > > > > > > > > > > > > > --------------------------------------------------------------------- > > > > > To unsubscribe, e-mail: dev-unsubscr...@cassandra.apache.org > > > > > For additional commands, e-mail: dev-h...@cassandra.apache.org > > > > > > > > > > > > > > > > > > > > > > > -- > > > Eduard Tudenhoefner > > > e. eduard.tudenhoef...@datastax.com > > > w. www.datastax.com > > > > > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@cassandra.apache.org For additional commands, e-mail: dev-h...@cassandra.apache.org
