+1

On 08/04/2020, 16:53, "Mick Semb Wever" <m...@apache.org> wrote:

    Can we agree on keeping such test changes out of CHANGES.txt ?
    
    We already don't put entries into CHANGES.txt if it is not a change
    from any previous release.
    
    There was some discussion before¹ about this, and the problem that
    being selective meant what ended up there being arbitrary. I think
    this can be solved with an easy rule of thumb that if it only touches
    *Test.java classes, or it is only about fixing a test, then it
    shouldn't be in CHANGES.txt. That means if the patch does touch any
    runtime code then you do still need to add an entry to CHANGES.txt.
    This avoids the whole "arbitrary" problem,  and maintains CHANGES.txt
    as user-facing formatted text to be searched through.
    
    If there's agreement I can commit to going through 4.0 changes and
    removing those that never touched runtime code.
    
    regards,
    Mick
    
    ¹) 
https://lists.apache.org/thread.html/a94946887081d8a408dd5cd01a203664f4d0197df713f0c63364a811%40%3Cdev.cassandra.apache.org%3E
    
    ---------------------------------------------------------------------
    To unsubscribe, e-mail: dev-unsubscr...@cassandra.apache.org
    For additional commands, e-mail: dev-h...@cassandra.apache.org
    
    



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@cassandra.apache.org
For additional commands, e-mail: dev-h...@cassandra.apache.org

Reply via email to