https://issues.apache.org/jira/browse/INFRA-19893
On Wed, Feb 26, 2020 at 8:12 PM Murukesh Mohanan <murukesh.moha...@gmail.com> wrote: > > Don't we have a pr@ mailing list for these? > > Yours, > Murukesh Mohanan > > > On Thu, 27 Feb 2020 at 03:56, GitBox <g...@apache.org> wrote: > > > dcapwell commented on a change in pull request #1: Introduce the extracted > > in-JVM DTest API > > URL: > > https://github.com/apache/cassandra-in-jvm-dtest-api/pull/1#discussion_r384691389 > > > > > > > > ########## > > File path: > > src/main/java/org/apache/cassandra/distributed/shared/Versions.java > > ########## > > @@ -0,0 +1,201 @@ > > +/* > > + * Licensed to the Apache Software Foundation (ASF) under one > > + * or more contributor license agreements. See the NOTICE file > > + * distributed with this work for additional information > > + * regarding copyright ownership. The ASF licenses this file > > + * to you under the Apache License, Version 2.0 (the > > + * "License"); you may not use this file except in compliance > > + * with the License. You may obtain a copy of the License at > > + * > > + * http://www.apache.org/licenses/LICENSE-2.0 > > + * > > + * Unless required by applicable law or agreed to in writing, software > > + * distributed under the License is distributed on an "AS IS" BASIS, > > + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or > > implied. > > + * See the License for the specific language governing permissions and > > + * limitations under the License. > > + */ > > + > > +package org.apache.cassandra.distributed.shared; > > + > > +import java.io.File; > > +import java.net.MalformedURLException; > > +import java.net.URL; > > +import java.nio.file.Paths; > > +import java.util.*; > > +import java.util.regex.Matcher; > > +import java.util.regex.Pattern; > > +import java.util.stream.Collectors; > > + > > +public class Versions > > > > Review comment: > > FYI one thing I have been seeing is that 2 distinct versions with the > > same major.minor is unclear which one gets picked up (think current branch > > is 3.0 and you pull in the 3.0 dtest for the previous release) > > > > This should be improved, but will be so much easier once this JIRA is > > completed! > > > > ---------------------------------------------------------------- > > This is an automated message from the Apache Git Service. > > To respond to the message, please log on to GitHub and use the > > URL above to go to the specific comment. > > > > For queries about this service, please contact Infrastructure at: > > us...@infra.apache.org > > > > > > With regards, > > Apache Git Services > > > > --------------------------------------------------------------------- > > To unsubscribe, e-mail: dev-unsubscr...@cassandra.apache.org > > For additional commands, e-mail: dev-h...@cassandra.apache.org > > > > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@cassandra.apache.org For additional commands, e-mail: dev-h...@cassandra.apache.org
