On Thu, Jan 23, 2020 at 9:09 AM Jeff Jirsa <jji...@gmail.com> wrote: > On Thu, Jan 23, 2020 at 6:18 AM Jeremiah Jordan <jerem...@datastax.com> > wrote: > > > It is the reviewer and authors job to make sure CI ran and didn’t > > introduce new failing tests, it doesn’t matter how they were ran. It is > > just as easy to let something through when “pr triggered” tests have a > > failure as it is tests manually linked from a JIRA comment, if the author > > and reviewer think the failures are not new. > > > > Agreed. Any committer who commits while tests are broken is ignoring > policy. Moving patch submission from one system to another won't somehow > make committers adhere to policy. >
Agreed but at the same time having a mechanism that reduces the amount of manual work required by the reviewer/committer (running tests/viewing reported results) should increase the likelihood the policy is adhered to if it’s not being adhered to currently. I would welcome information being automatically added from CI during review and if PRs are an easy way to accomplish that in the future then +1. > > > > > If someone want to setup some extra niceties, like auto triggered builds > > or something, to happen if people use the PR workflow, then I see no > > problem there. But I don’t think we need to force use of PRs. > > > > This is why I don’t think we need to “switch” to using PR’s. There is no > > need to switch. People can “also” use PRs. If someone who likes the PR > > workflow sets up some more nice stuff to happen when it is used, that > would > > probably encourage more people to do things that way. But it doesn’t need > > to be forced. > > > > Agreed. > +1. I don’t think we need requirement yet as much as encouragement. If some folks start using this approach, hopefully it’s overall use will spread as others see the benefits. I used it for the first time on my most recent ticket and have found it convenient so far. We can always revisit requirement if failures on trunk continue to be a problem. Better visibility would be a good start. Jordan
