I believe I read half your email, my brain assessed that I agreed w/you and understood what you were saying, and then bounced down the thread; that's completely on me and in no way a phrasing error on your part.
You are 100% correct and are supporting my (apparently multiple) bad habits. +1 again! On Wed, May 15, 2019 at 9:19 AM Benedict Elliott Smith <bened...@apache.org> wrote: > I should clarify that by “cleanly formatted link to GitHub” I meant > supporting exactly this. > > > On 15 May 2019, at 14:17, Joshua McKenzie <jmcken...@apache.org> wrote: > > > > +1 here, though I also liked it when people made it an href in comments > so > > my lazy ass busy and efficient self could click it. =/ > > > > On Wed, May 15, 2019 at 3:39 AM Sam Tunnicliffe <s...@beobal.com> wrote: > > > >> +1 > >> > >>> On 14 May 2019, at 20:10, Benedict Elliott Smith <bened...@apache.org> > >> wrote: > >>> > >>> It will be possible to insert n/a. It will simply be a text field - > >> Jira doesn’t know anything about the concept of a SHA, and I don’t > intend > >> to introduce validation logic. It’s just a logical and consistent place > >> for it to live, and a strong reminder to include it. My intention is > for > >> it to be a text field supporting Jira markup, like Test and Doc Plan, so > >> that we can insert cleanly formatted links to GitHub just like we do > now in > >> comments. > >>> > >>> > >>> > >>>> On 14 May 2019, at 20:04, Dinesh Joshi <djo...@apache.org> wrote: > >>>> > >>>> I am +0.5 on this. I think it is a good idea. I want to ensure that we > >> capture use-cases such as Tasks that may not have a git commit > associated > >> with them. There might be tickets that may have multiple git commits > across > >> repos. SVN commits may also need to be handled. > >>>> > >>>> Dinesh > >>>> > >>>>> On May 14, 2019, at 11:34 AM, Jeff Jirsa <jji...@gmail.com> wrote: > >>>>> > >>>>> Please > >>>>> > >>>>> -- > >>>>> Jeff Jirsa > >>>>> > >>>>> > >>>>>> On May 14, 2019, at 7:53 AM, Benedict Elliott Smith < > >> bened...@apache.org> wrote: > >>>>>> > >>>>>> How would people feel about introducing a field for the (git) commit > >> SHA, to be required on (Jira) commit? > >>>>>> > >>>>>> The norm is that we comment the SHA, but given this is the norm > >> perhaps we should codify it instead, while we have the chance? It would > >> also make it easier to find. > >>>>>> > --------------------------------------------------------------------- > >>>>>> To unsubscribe, e-mail: dev-unsubscr...@cassandra.apache.org > >>>>>> For additional commands, e-mail: dev-h...@cassandra.apache.org > >>>>>> > >>>>> > >>>>> --------------------------------------------------------------------- > >>>>> To unsubscribe, e-mail: dev-unsubscr...@cassandra.apache.org > >>>>> For additional commands, e-mail: dev-h...@cassandra.apache.org > >>>>> > >>>> > >>>> > >>>> --------------------------------------------------------------------- > >>>> To unsubscribe, e-mail: dev-unsubscr...@cassandra.apache.org > >>>> For additional commands, e-mail: dev-h...@cassandra.apache.org > >>>> > >>> > >>> > >>> --------------------------------------------------------------------- > >>> To unsubscribe, e-mail: dev-unsubscr...@cassandra.apache.org > >>> For additional commands, e-mail: dev-h...@cassandra.apache.org > >>> > >> > >> > >> --------------------------------------------------------------------- > >> To unsubscribe, e-mail: dev-unsubscr...@cassandra.apache.org > >> For additional commands, e-mail: dev-h...@cassandra.apache.org > >> > >> > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@cassandra.apache.org > For additional commands, e-mail: dev-h...@cassandra.apache.org > >
