Hi, I really like github’s workflow. If you don’t abuse it you get a history of the entire review process.
Right now some people have a workflow that involves force pushing and deleting branches. If you delete branches I think the pull requests are still valid so people can still do it (although I don’t), but force pushing on the branch containing your work history is not compatible with using github pull requests. We don’t need to use github to merge we can just close the pull request. I don’t see value in having code review process in JIRA because it’s not good at it. Having discussion mixed in JIRA and a code review tool is not great, but the status quo is an unreadable for me. I also leave fewer comments because of how difficult it is to comment on code. Maybe this is less terrible if you use github’s issue tracker (haven’t done it), but that is not an option. Maybe what we want is to use the Atlassian review tool to get “proper” integration with JIRA? Regards, Ariel > On Jul 8, 2015, at 3:21 PM, Josh McKenzie <jmcken...@apache.org> wrote: > > As some of you might have noticed, Tyler and I tossed around a couple of > thoughts yesterday regarding the best way to perform larger reviews on JIRA. > > I've been leaning towards the approach Benedict's been taking lately > w/putting comments inline on a branch for the initial author to inspect as > that provides immediate locality for a reviewer to write down their > thoughts and the same for the initial developer to ingest them. One > downside to that approach is that the extra barrier to entry makes it more > of a 1-on-1 conversation rather than an open discussion via JIRA comments. > Also, if one deletes branches from github we then lose our discussion > history on the review process which is a big problem for digging into why > certain decisions were made or revised during the process. > > On the competing side, monster comments like this > <https://issues.apache.org/jira/browse/CASSANDRA-6477?focusedCommentId=14617221&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14617221> > (which > is one of multiple to come) are burdensome to create and map into a JIRA > comment and, in my experience, also a burden to map back into the code-base > as a developer. Details are lost in translation; I'm comfortable labeling > this a sub-optimal method of communication. > > So what to do? > > -- > Joshua McKenzie
