On 12/01/2014 06:22 PM, Jay Patel wrote:
Can anyone help review this patch? It has been more than 2 moths & we're
going live soon. It's currently assigned to Benedict for the review. Let me
know if I should reassign to someone else. Thanks for your help!
For your particular case, "going live" may be the best validation test
of your patch. Comment in JIRA from your production use case experience.
There are currently 64 patches available, which is awesome! ..and
unfortunate when they wait for review. The project is aware of the
backlog[0] and it takes time to dig through them all. Everyone can help.
Not to single you out, but have you reviewed someone else's patch today? :)
- Does it follow code style[1].
- Does it apply cleanly.
- Does it fix the problem.
- Does it regress something.
- Comment on JIRA.
[0]
http://mail-archives.apache.org/mod_mbox/cassandra-dev/201410.mbox/%3CCALdd-zjmvp7JOtguZ_k951RQHDtFt1cthX%3DRnHQ332C%3DgAZbjw%40mail.gmail.com%3E
[1] http://wiki.apache.org/cassandra/CodeStyle
--
Warm regards,
Michael Shuler
