Thanks Stamatis for preparing this release. My vote is: -1 rubenql (PMC) - Release notes: ok - Checksum: ok - Signature: ok - Diff source release and git repository: ok - Build + tests: ok - Calcite-based application test suite: KO There seems to be a regression in SqlToRelConverter introduced by [1] which IMO would be a blocker, I have created a ticket with all the information [2]
Best, Ruben [1] https://issues.apache.org/jira/browse/CALCITE-6413 [2] https://issues.apache.org/jira/browse/CALCITE-6885 On Wed, Mar 12, 2025 at 2:17 AM Xiong Duan <xi...@apache.org> wrote: > +1 Xiong Duan (committer) > > Thanks Stamatis for preparing the RC, this is what I have checked: > > - verified gpg signature: OK > - verified package checksum: OK > - verified gradle build from sources: OK > - building commit and running tests: OK > - checked release notes: I left some small suggestions in the PR > - $ ./gradlew build：OK > > Environment: > ➜ calcite git:(calcite-1.39.0-rc0) ./gradlew -version > > ------------------------------------------------------------ > Gradle 8.7 > ------------------------------------------------------------ > > Build time: 2024-03-22 15:52:46 UTC > Revision: 650af14d7653aa949fce5e886e685efc9cf97c10 > > Kotlin: 1.9.22 > Groovy: 3.0.17 > Ant: Apache Ant(TM) version 1.10.13 compiled on January 4 2023 > JVM: 21.0.4 (Amazon.com Inc. 21.0.4+7-LTS) > OS: Mac OS X 12.7.6 x86_64 > > ➜ calcite git:(calcite-1.39.0-rc0) Java -version > openjdk version "21.0.4" 2024-07-16 LTS > OpenJDK Runtime Environment Corretto-21.0.4.7.1 (build 21.0.4+7-LTS) > OpenJDK 64-Bit Server VM Corretto-21.0.4.7.1 (build 21.0.4+7-LTS, > mixed mode, sharing) > > Alessandro Solimando <alessandro.solima...@gmail.com> 于2025年3月11日周二 > 20:41写道： > > > > +1 asolimando (committer) > > > > Thanks Stamatis for preparing the RC, this is what I have checked: > > > > - verified gpg signature: OK [1] > > > > - verified package checksum: OK [2] > > > > - verified gradle build from sources: OK [3] > > > > - building commit and running tests: OK [4] > > > > - checked release notes: OK > > > > - checked a few modules in the Maven repository: OK > > > > - checking difference with the git folder: OK [5] > > > > - environment used [6] > > > > Best regards, > > Alessandro > > > > > --------------------------------------------------------------------------------------------- > > > > [1] > > > > $ curl "https://downloads.apache.org/calcite/KEYS"; | gpg --import > > > > $ gpg --verify apache-calcite-1.39.0-src.tar.gz.asc > > apache-calcite-1.39.0-src.tar.gz > > > > [2] > > > > $ diff <(cat apache-calcite-1.39.0-src.tar.gz.sha512) <(shasum -a 512 > > apache-calcite-1.39.0-src.tar.gz) > > > > [3] > > > > $ cp ~/git_upstream/calcite/gradlew . > > > > $ cp -r ~/git_upstream/calcite/gradle/wrapper gradle > > > > $ ./gradlew build > > > > [4] > > > > $ ./gradlew build > > > > [5] > > > > $ diff -qr . ~/git_upstream/calcite | grep -v gradle | grep -v idea > > > > (nothing to report) > > > > [6] > > > > $ ./gradlew -version > > > > ------------------------------------------------------------ > > > > Gradle 8.7 > > > > ------------------------------------------------------------ > > > > Build time: 2024-03-22 15:52:46 UTC > > > > Revision: 650af14d7653aa949fce5e886e685efc9cf97c10 > > > > Kotlin: 1.9.22 > > > > Groovy: 3.0.17 > > > > Ant: Apache Ant(TM) version 1.10.13 compiled on January 4 2023 > > > > JVM: 1.8.0_352 (Azul Systems, Inc. 25.352-b08) > > > > OS: Mac OS X 14.4.1 aarch64 > > > > $ java -version > > > > openjdk version "1.8.0_352" > > > > OpenJDK Runtime Environment (Zulu 8.66.0.15-CA-macos-aarch64) (build > > 1.8.0_352-b08) > > > > OpenJDK 64-Bit Server VM (Zulu 8.66.0.15-CA-macos-aarch64) (build > > 25.352-b08, mixed > > > > > > On Mon, 10 Mar 2025 at 23:07, Francis Chuang <francischu...@apache.org> > > wrote: > > > > > Thank you for being RM for this release, Stamatis! > > > > > > My vote is: +1 francischuang (PMC) > > > > > > - Verified GPG signature - OK > > > - Verified SHA512 - OK > > > - Diffed source release and git repository - OK > > > - Checked release notes on tag > > > ( > > > > https://github.com/apache/calcite/blob/calcite-1.39.0-rc0/site/_docs/history.md > ) > > > > > > - OK > > > - Checked year and versions in NOTICE, README and HOWTO - OK > > > - Ran tests (gradle check) - OK > > > - Spot checked Nexus artifacts - OK > > > > > > Environment: > > > Eclipse-temurin:23 docker container in WSL2 (Ubuntu 24.04.2) on Windows > > > 11 24h2 > > > > > > $ docker version > > > Client: > > > Version: 28.0.1 > > > API version: 1.48 > > > Go version: go1.23.6 > > > Git commit: 068a01e > > > Built: Wed Feb 26 10:40:04 2025 > > > OS/Arch: linux/amd64 > > > Context: default > > > > > > Server: Docker Desktop 4.0.0 () > > > Engine: > > > Version: 28.0.1 > > > API version: 1.48 (minimum version 1.24) > > > Go version: go1.23.6 > > > Git commit: bbd0a17 > > > Built: Wed Feb 26 10:41:16 2025 > > > OS/Arch: linux/amd64 > > > Experimental: false > > > containerd: > > > Version: 1.7.25 > > > GitCommit: bcc810d6b9066471b0b6fa75f557a15a1cbf31bb > > > runc: > > > Version: 1.2.4 > > > GitCommit: v1.2.4-0-g6c52b3f > > > docker-init: > > > Version: 0.19.0 > > > GitCommit: de40ad0 > > > > > > $ gradle -v > > > > > > ------------------------------------------------------------ > > > Gradle 8.7 > > > ------------------------------------------------------------ > > > > > > Build time: 2024-03-22 15:52:46 UTC > > > Revision: 650af14d7653aa949fce5e886e685efc9cf97c10 > > > > > > Kotlin: 1.9.22 > > > Groovy: 3.0.17 > > > Ant: Apache Ant(TM) version 1.10.13 compiled on January 4 2023 > > > JVM: 23.0.2 (Eclipse Adoptium 23.0.2+7) > > > OS: Linux 5.15.167.4-microsoft-standard-WSL2 amd64 > > > > > > $ java --version > > > openjdk 23.0.2 2025-01-21 > > > OpenJDK Runtime Environment Temurin-23.0.2+7 (build 23.0.2+7) > > > OpenJDK 64-Bit Server VM Temurin-23.0.2+7 (build 23.0.2+7, mixed mode, > > > sharing) > > > > > > Francis > > > > > > On 11/03/2025 5:38 am, Stamatis Zampetakis wrote: > > > > Hi all, > > > > > > > > I have created a build for Apache Calcite 1.39.0, release > > > > candidate 0. > > > > > > > > Thanks to everyone who has contributed to this release. > > > > > > > > You can read the release notes here: > > > > > > > > https://github.com/apache/calcite/blob/calcite-1.39.0-rc0/site/_docs/history.md > > > > > > > > The commit to be voted upon: > > > > > > > > https://gitbox.apache.org/repos/asf?p=calcite.git;a=commit;h=fc416167c45c1f5308df58e4880c18fcc1cdc47c > > > > > > > > Its hash is fc416167c45c1f5308df58e4880c18fcc1cdc47c > > > > > > > > Tag: > > > > https://github.com/apache/calcite/tree/calcite-1.39.0-rc0 > > > > > > > > The artifacts to be voted on are located here: > > > > > https://dist.apache.org/repos/dist/dev/calcite/apache-calcite-1.39.0-rc0 > > > > (revision 75492) > > > > > > > > The hashes of the artifacts are as follows: > > > > > > > > 279486e0154edb144c6d48f0a5da3a12e95b1bcbdceac0d73a3b01304ca9159cadd508b05879c22572e0f4f8ef3e484cf8179d791280deece60883074c6ec4a8 > > > > *apache-calcite-1.39.0-src.tar.gz > > > > > > > > A staged Maven repository is available for review at: > > > > > > > > https://repository.apache.org/content/repositories/orgapachecalcite-1243/org/apache/calcite/ > > > > > > > > Release artifacts are signed with the following key: > > > > https://people.apache.org/keys/committer/zabetak.asc > > > > https://www.apache.org/dist/calcite/KEYS > > > > > > > > To create the jars and test Apache Calcite: "gradle build" > > > > (Requires an appropriate Gradle/JDK installation.) > > > > > > > > Please vote on releasing this package as Apache Calcite 1.39.0. > > > > Everyone is welcome to vote. Your vote should contain the line > > > > 'code name (role)', where > > > > * 'code' is +1, 0 or -1 as below; > > > > * 'name' is your ASF id if you have one, else your real name; > > > > * 'role' is 'community', 'committer' or 'PMC member'. > > > > > > > > [ ] +1 Release this package as Apache Calcite 1.39.0 > > > > [ ] 0 I don't feel strongly about it, but I'm okay with the release > > > > [ ] -1 Do not release this package because... > > > > > > > > The vote is open for the next 72 hours (closing at > > > > 2025-03-13T18:00:00Z) and passes if a majority of > > > > at least three +1 votes by PMC members are cast. > > > > > > > > Here is my vote: > > > > > > > > +1 zabetak (PMC member) > > > > > > >
