Thanks for reporting this, Stamatis. I don't think it's a show-stopper
at the moment, but I'd definitely want to have it fixed for the next
Avatica release. I've tagged CALCITE-6851 with a fix version of 1.27.0.
I'll go ahead and finalize the vote for 1.26.0
On 22/02/2025 6:55 am, Stamatis Zampetakis wrote:
Ubuntu 20.04.6 LTS, jdk1.8.0_421, Gradle wrapper, Gradle 8.7
* Checked signatures and checksums OK
* Checked diff between repo and artifacts OK
* Went over release note OK
* Checked README, NOTICE, LICENSE OK with some minor issues that still persist
* All source files have ASF headers (grep -RiL "Licensed to the
Apache Software Foundation") OK
* No unexpected binary files (find . -type f -exec file {} \; | grep
-v text) OK
* Checked LICENSE, NOTICE, signature, and checksum for
avatica-core-1.26.0.jar in nexus OK
* Built from git tag and run tests (./gradlew build) OK on retry [1]
* Built from source artifacts and run tests (gradle build) OK on retry [1]
Worth mentioning that I encountered CALCITE-6851 [1] when building the
project. Given that the build usually passes on retry I will still
vote positively for making this release although it might provide a
negative impression for newcomers. I will leave the final decision to
the RM.
+1 (binding)
Best,
Stamatis
[1] https://issues.apache.org/jira/browse/CALCITE-6851
On Thu, Feb 20, 2025 at 1:54 PM Alessandro Solimando
<alessandro.solima...@gmail.com> wrote:
+1 (non-binding) after verifying as follows:
- verified gpg signature: OK [1]
- verified package checksum: OK [2]
- verified gradle build from sources: OK [3]
- building commit and running tests: OK [4]
- checked release notes: OK
- checked few modules in the Maven repository: OK
- checking difference in folder: OK [5]
- environment used (as per “./gradlew -version”):
JVM: 1.8.0_352 (Azul Systems, Inc. 25.352-b08)
OS: Mac OS X 14.4.1 aarch64
Thanks to Francis and to all the contributors of the release!
Best regards,
Alessandro
[1]
$ curl "https://downloads.apache.org/calcite/KEYS"; | gpg --import
$ gpg --verify apache-calcite-avatica-1.26.0-src.tar.gz.asc
apache-calcite-avatica-1.26.0-src.tar.gz
[2]
$ diff <(cat apache-calcite-avatica-1.26.0-src.tar.gz.sha512) <(shasum -a
512 apache-calcite-avatica-1.26.0-src.tar.gz)
[3]
$ cp ~/git_upstream/calcite-avatica/gradlew .
$ cp -r ~/git_upstream/calcite-avatica/gradle/wrapper gradle
$ ./gradlew build -Prelease -PskipSign
$ docker-compose run test
[4]
$ ./gradlew build -Prelease -PskipSign
$ docker-compose run test
(checked CI on github for the commit)
[5]
$ diff -qr . ~/git_upstream/calcite-avatica | grep -v gradle | grep -v idea
(nothing worth mentioning)
On Thu, 20 Feb 2025 at 19:29, Ruben Q L <rube...@gmail.com> wrote:
Thanks Francis for preparing the release once again.
- Release notes: ok
- Signature: ok
- Checksum: ok
- Local build: ok
+1 (binding)
On Wed, Feb 19, 2025 at 9:47 AM Istvan Toth <st...@cloudera.com.invalid>
wrote:
+1 (non binding)
* Eyeballed release notes: OK
* Checked source artifact signature: OK
* Checked source artifact checksum: OK
* Built it locally, and ran the Phoenix Query Server test suite with it:
OK
Istvan
On Wed, Feb 19, 2025 at 12:10 AM Francis Chuang <
francischu...@apache.org>
wrote:
Hi all,
I have created a build for Apache Calcite Avatica 1.26.0,
releasecandidate 0.
Thanks to everyone who has contributed to this release.
You can read the release notes here:
https://github.com/apache/calcite-avatica/blob/avatica-1.26.0-rc0/site/_docs/history.md
The commit to be voted upon:
https://gitbox.apache.org/repos/asf?p=calcite-avatica.git;a=commit;h=a4e7987104dfcfd490d76bc30734d4ed92105c02
Its hash is a4e7987104dfcfd490d76bc30734d4ed92105c02
Tag:
https://github.com/apache/calcite-avatica/releases/tag/avatica-1.26.0-rc0
The artifacts to be voted on are located here:
https://dist.apache.org/repos/dist/dev/calcite/apache-calcite-avatica-1.26.0-rc0
(revision 74974)
The hashes of the artifacts are as follows:
50207e71243e0330525a6979b34c5ba8cbd03cc704486ba0ffb2e8a244d6e0bf6682248ccc9d5de02193f444e5eda9505d7b219dc0ebe3dd8be5fe957ffcbac0
*apache-calcite-avatica-1.26.0-src.tar.gz
A staged Maven repository is available for review at:
https://repository.apache.org/content/repositories/orgapachecalcite-1236/org/apache/calcite/
Release artifacts are signed with the following key:
https://people.apache.org/keys/committer/francischuang.asc
https://www.apache.org/dist/calcite/KEYS
To create the jars and test Apache Calcite Avatica: "gradle build
-Prelease -PskipSign".
If you do not have a Java/Gradle environment available, you can run the
tests using docker. To do so, install docker and docker-compose, then
run "docker compose run test" from the root of the directory.
Please vote on releasing this package as Apache Calcite Avatica 1.26.0.
The vote is open for the next 72 hours and passes if a majority of at
least three +1 PMC votes are cast.
[ ] +1 Release this package as Apache Calcite Avatica 1.26.0
[ ] 0 I don't feel strongly about it, but I'm okay with the release
[ ] -1 Do not release this package because...
Here is my vote:
+1 (binding)
Francis
--
*István Tóth* | Sr. Staff Software Engineer
*Email*: st...@cloudera.com
cloudera.com <https://www.cloudera.com>
[image: Cloudera] <https://www.cloudera.com/>
[image: Cloudera on Twitter] <https://twitter.com/cloudera> [image:
Cloudera on Facebook] <https://www.facebook.com/cloudera> [image:
Cloudera
on LinkedIn] <https://www.linkedin.com/company/cloudera>
------------------------------
------------------------------
