Thanks for highlighting this issue Hongyu it looks like a problem for users playing with jdk17+ and I tend to cancel this RCif there is no objections
I have created an issue for that CALCITE-6387[1] I'm not sure about adding it in the documentation since it will make it harder for users... I would suggest to add this flag in corresponding module gradle file [1] https://issues.apache.org/jira/browse/CALCITE-6387 On Sat, Apr 27, 2024 at 8:45 AM Hongyu Guo <guohongyu...@gmail.com> wrote: > An error will be thrown when running tests with jdk17 (or with jdk11, 19): > ``` > java.lang.RuntimeException: Failed to initialize MemoryUtil. You must start > Java with `--add-opens=java.base/java.nio=ALL-UNNAMED` (See > https://arrow.apache.org/docs/java/install.html) > at > org.apache.arrow.memory.util.MemoryUtil.<clinit>(MemoryUtil.java:143) > ``` > > A quick way to fix it is by executing > `_JAVA_OPTIONS="--add-opens=java.base/java.nio=ALL-UNNAMED" gradle test`, > so I think we should add some docs about this. > > > On Fri, Apr 26, 2024 at 6:26 PM Ruben Q L <rube...@gmail.com> wrote: > > > Thanks Sergey for preparing this new RC. > > > > - Release notes: ok (minor comment on the PR) > > - Checksum: ok > > - Signature: ok > > - Diff source release and git repository: ok > > - Build + tests (from both RC commit and source artifacts): ok > > - Calcite-based application test suite: ok > > > > +1 (binding) > > > > > > On Fri, Apr 26, 2024 at 10:51 AM Francis Chuang < > francischu...@apache.org> > > wrote: > > > > > Thanks for making rc2 available for voting, Sergey and thanks to > > > Stamatis for fixing the bug causing tests to fail when run from the > > > source distribution. > > > > > > My vote is: +1 (binding) > > > > > > - Verified GPG signature - OK > > > - Verified SHA512 - OK > > > - Diffed source release and git repository - OK > > > - Checked release notes on tag > > > ( > > > > > > https://github.com/apache/calcite/blob/calcite-1.37.0-rc2/site/_docs/history.md > > ) > > > > > > - OK > > > - Checked year and versions in NOTICE, README and HOWTO - OK > > > - Ran tests (gradle check) - OK > > > - Spot checked Nexus artifacts - OK > > > > > > Repeating my comment from the previous vote regarding some contributors > > > being listed by their username rather than their full name: I think it > > > would be better to put in their real names if they are known. These can > > > usually be retrieved from their GitHub profiles. This is a minor issue > > > that can be dealt with after the release. > > > > > > Environment: > > > Eclipse-temurin:8 docker container in WSL2 (Ubuntu 22.04.4) on Windows > > > 11 23h2 > > > > > > $ docker version > > > Client: > > > Cloud integration: v1.0.35+desktop.13 > > > Version: 26.0.0 > > > API version: 1.45 > > > Go version: go1.21.8 > > > Git commit: 2ae903e > > > Built: Wed Mar 20 15:16:45 2024 > > > OS/Arch: linux/amd64 > > > Context: default > > > > > > Server: Docker Desktop > > > Engine: > > > Version: 26.0.0 > > > API version: 1.45 (minimum version 1.24) > > > Go version: go1.21.8 > > > Git commit: 8b79278 > > > Built: Wed Mar 20 15:18:01 2024 > > > OS/Arch: linux/amd64 > > > Experimental: false > > > containerd: > > > Version: 1.6.28 > > > GitCommit: ae07eda36dd25f8a1b98dfbf587313b99c0190bb > > > runc: > > > Version: 1.1.12 > > > GitCommit: v1.1.12-0-g51d5e94 > > > docker-init: > > > Version: 0.19.0 > > > GitCommit: de40ad0 > > > > > > $ gradle -v > > > > > > ------------------------------------------------------------ > > > Gradle 7.6.1 > > > ------------------------------------------------------------ > > > > > > Build time: 2023-02-24 13:54:42 UTC > > > Revision: 3905fe8ac072bbd925c70ddbddddf4463341f4b4 > > > > > > Kotlin: 1.7.10 > > > Groovy: 3.0.13 > > > Ant: Apache Ant(TM) version 1.10.11 compiled on July 10 2021 > > > JVM: 1.8.0_402 (Temurin 25.402-b06) > > > OS: Linux 5.15.146.1-microsoft-standard-WSL2 amd64 > > > > > > $ java -version > > > openjdk version "1.8.0_402" > > > OpenJDK Runtime Environment (Temurin)(build 1.8.0_402-b06) > > > OpenJDK 64-Bit Server VM (Temurin)(build 25.402-b06, mixed mode) > > > > > > Francis > > > On 26/04/2024 6:28 am, Sergey Nuyanzin wrote: > > > > Hi all, > > > > > > > > I have created a build for Apache Calcite 1.37.0, release > > > > candidate 2 (there was an issue in subject name and actual rc number, > > so > > > > for safety it is 2). > > > > > > > > Thanks to everyone who has contributed to this release. > > > > > > > > You can read the release notes here: > > > > > > > > > > https://github.com/apache/calcite/blob/calcite-1.37.0-rc2/site/_docs/history.md > > > > > > > > The commit to be voted upon: > > > > > > > > > > https://gitbox.apache.org/repos/asf?p=calcite.git;a=commit;h=6d8175111ec72f65cb12815d5d519680f62dfd08 > > > > > > > > Its hash is 6d8175111ec72f65cb12815d5d519680f62dfd08 > > > > > > > > Tag: > > > > https://github.com/apache/calcite/tree/calcite-1.37.0-rc2 > > > > > > > > The artifacts to be voted on are located here: > > > > > > https://dist.apache.org/repos/dist/dev/calcite/apache-calcite-1.37.0-rc2 > > > > (revision 68794) > > > > > > > > The hashes of the artifacts are as follows: > > > > > > > > > > 373665630145ac52221eeec8456c295c868dfe6a15ded4b7d92e929db769d3c13d21409478c57b93671bca703bf183a24069def42d33d078a5cdec6a2ec69368 > > > > *apache-calcite-1.37.0-src.tar.gz > > > > > > > > A staged Maven repository is available for review at: > > > > > > > > > > https://repository.apache.org/content/repositories/orgapachecalcite-1228/org/apache/calcite/ > > > > > > > > Release artifacts are signed with the following key: > > > > https://people.apache.org/keys/committer/snuyanzin.asc > > > > https://www.apache.org/dist/calcite/KEYS > > > > > > > > To create the jars and test Apache Calcite: "gradle build" > > > > (requires an appropriate Gradle/JDK installation) > > > > > > > > Please vote on releasing this package as Apache Calcite 1.37.0. > > > > > > > > The vote is open for the next 72 hours(I think we can extend it a bit > > > > given the fact that there is a weekend soon) and passes if a majority > > of > > > at > > > > least three +1 PMC votes are cast. > > > > > > > > [ ] +1 Release this package as Apache Calcite 1.37.0 > > > > [ ] 0 I don't feel strongly about it, but I'm okay with the release > > > > [ ] -1 Do not release this package because... > > > > > > > > Here is my vote: > > > > > > > > +1 (binding) > > > > > > > > > > > > > > -- Best regards, Sergey
