I have already approved https://github.com/apache/calcite-avatica/pull/234 If Sergey is not available, any committer (including me) can merge it.
Istvan On Mon, Mar 25, 2024 at 7:10 AM Mihai Budiu <mbu...@gmail.com> wrote: > I have authored the first two PRs in this list, they are certainly ready > on the Avatica side, and they have been approved and are ready to merge. > > I have made corresponding PR on the Calcite side, and > I have been trying to test them with Calcite, but it's not easy. > > First, there is a flag in Calcite called localAvatica, which is supposed > to build using the a version of Avatica on the local disk. That doesn't > work, because seemingly some packages have to be updated, including gradle. > > I have tried replacing the avatica-core and avatica-server jars in the > gradle build files with local versions. But Calcite still doesn't build: > some APIs have changed in Avatica, and Calcite will not build with the new > APIs. In particular, the Avatica server Main class seems to require > different argument types. > > Maybe there are other problems as well, but I got blocked on these. > > Is it OK to merge the PRs in Avatica if the Avatica CI fails? The CI fails > because one of the tasks is to test the Calcite core, and clearly that will > fail until Calcite itself is upgraded. > > I could disable the failing tests in Calcite core temporarily, but I > suspect other Calcite projects will fail, which are not being tested with > Avatica's CI. > > I appreciate any help. > Mihai > > ________________________________ > From: Francis Chuang <francischu...@apache.org> > Sent: Sunday, March 24, 2024 10:59 PM > To: dev@calcite.apache.org <dev@calcite.apache.org> > Subject: Towards Avatica 1.25.0 > > Hey everyone, > > I want to start the discussion for releasing Avatica 1.25.0 before we > release Calcite 1.37.0. > > Relevant discussions are here: > - Calcite 1.37.0: > https://lists.apache.org/thread/k27rwmhggmsbvwmgxs9fydcw2f0hook8 > - Avatica PRs: > https://lists.apache.org/list?dev@calcite.apache.org:lte=1M:avatica > > I think it would be a good idea to get these PRs in for the release: > - https://github.com/apache/calcite-avatica/pull/241 > - https://github.com/apache/calcite-avatica/pull/238 > - https://github.com/apache/calcite-avatica/pull/234 > > Community members, please take a look at those PRs and leave your > reviews if necessary. If possible, please consider merging as well. > > I hope to make rc0 available for voting end of this week or early next > week. Does this schedule suit? > > Francis >
