Yes, non-committers can review. We welcome it - and in fact reviewing is a good way to earn merit and become a committer.
Of course the PR can only be committed by a committer. But reviewing - and the back-and-forth after a review, including reviewing revisions to the PR - is a major part of the work. On Fri, Mar 17, 2023 at 11:46 AM Charles Givre <[email protected]> wrote: > > Can non-Calcite committers assist with code review? I'd be happy to help out. > Best, > -- C > > > On Mar 17, 2023, at 2:32 PM, Tanner Clary <[email protected]> > > wrote: > > > > Hello Calcite Developers, > > > > > > My name is Tanner and I have been working to enable several functions for > > the BigQuery dialect over the last few months. I have four open pull > > requests at the moment that could use a review if anyone has the time. I > > would really appreciate it. Three of them have already been reviewed once > > and are now awaiting re-review/merge (denoted with *). > > > > The JIRA Issues and their corresponding Pull Requests are: > > > > > > - [CALCITE-5554 <https://issues.apache.org/jira/browse/CALCITE-5554>] - > > [PR > > #3094 <https://github.com/apache/calcite/pull/3094>]* > > - [CALCITE-5564 <https://issues.apache.org/jira/browse/CALCITE-5565>] - > > [PR > > #3099 <https://github.com/apache/calcite/pull/3099>]* > > - [CALCITE-5580 <https://issues.apache.org/jira/browse/CALCITE-5580>] - > > [PR > > #3109 <https://github.com/apache/calcite/pull/3109>] > > - [CALCITE-5585 <https://issues.apache.org/jira/browse/CALCITE-5585>] - > > [PR > > #3114 <https://github.com/apache/calcite/pull/3114>]* > > > > > > Thank you in advance to anyone who is able to assist! > > > > Best, > > > > Tanner Clary >
