I agree that this is a blocker. Sergey’s PR illustrates the problem but isn’t a great fix. The fix should look for “flag” literals in order to distinguish between the function variants. The test case should be in a Quidem test rather than RexBuikderTest.
Tanner, do you have time to work on a revised PR? In any case I’ll merge a fix in the next 8 hours. Julian > On Jan 26, 2023, at 12:09 AM, Ruben Q L <rube...@gmail.com> wrote: > > According to our Jira dashboard [1] it seems there's still one blocker > issue for 1.33 [2] (it was categorized as blocker because it was a > regression). > I guess we should complete this ticket before starting the RC. > > > [1] > https://issues.apache.org/jira/secure/Dashboard.jspa?selectPageId=12333950 > [2] https://issues.apache.org/jira/browse/CALCITE-5489 > >> On Thu, Jan 26, 2023 at 3:44 AM Jess Balint <jbal...@gmail.com> wrote: >> >> Great, I'll start the build. Let's hold off on further commits please. >> >>> On Wed, Jan 25, 2023 at 6:48 PM Julian Hyde <jh...@apache.org> wrote: >>> >>> I have merged it: >>> >>> >> https://github.com/apache/calcite/commit/20014b6c5b9b57d29248206f19d63ef50f7a5c0f >>> >>> On Wed, Jan 25, 2023 at 2:03 PM Jess Balint <jbal...@gmail.com> wrote: >>>> >>>> I'll merge it and then start the rc build. >>>> >>>> On Wed, Jan 25, 2023, 13:04 Julian Hyde <jh...@apache.org> wrote: >>>> >>>>> Oops, I have one more PR ready to merge [1]. If the main branch is >> not >>>>> yet closed, let me know, Jess. >>>>> >>>>> Julian >>>>> >>>>> [1] https://issues.apache.org/jira/browse/CALCITE-5283 >>>>> >>>>> On Wed, Jan 25, 2023 at 8:14 AM Julian Hyde <jhyde.apa...@gmail.com> >>>>> wrote: >>>>>> >>>>>> I agree. I merged some PRs last night (before I saw this email) >> but I >>>>> agree it’s time for an RC. I’ll stop pushing to main. Have at it, >> Jess! >>>>>> >>>>>> Julian >>>>>> >>>>>>> On Jan 24, 2023, at 2:03 PM, Stamatis Zampetakis < >>> zabe...@gmail.com> >>>>> wrote: >>>>>>> >>>>>>> Thanks for staying on top of this Jess! >>>>>>> >>>>>>> Apart from the two JIRAs marked as blockers (regressions from >>> 1.32.0) I >>>>>>> don't think we should wait much more for getting the release out. >>>>>>> >>>>>>> Best, >>>>>>> Stamatis >>>>>>> >>>>>>>> On Tue, Jan 24, 2023 at 10:59 PM Jess Balint <jbal...@gmail.com >>> >>>>> wrote: >>>>>>>> >>>>>>>> The Avatica release is out. I've done what I can on outstanding >>>>> reviews: >>>>>>>> >>>>>>>> >>>>> >>> >> https://issues.apache.org/jira/secure/Dashboard.jspa?selectPageId=12333950 >>>>>>>> >>>>>>>> Do we have any final requests for PRs to be merged or should I >>> create >>>>> the >>>>>>>> rc build? >>>>>>>> >>>>>>>>> On Sun, Jan 15, 2023 at 2:20 PM Julian Hyde <jh...@apache.org> >>>>> wrote: >>>>>>>>> >>>>>>>>> I have created a jira case to track this release: >>>>>>>>> https://issues.apache.org/jira/browse/CALCITE-5481 >>>>>>>>> >>>>>>>>> Also, I am proposing to make a quick Avatica 1.23 release. If >> the >>>>> plans >>>>>>>>> work out, it will be ready for inclusion in Calcite 1.33 from >>>>> Thursday. >>>>>>>>> >>>>>>>>> Julian >>>>>>>>> >>>>>>>>> >>>>>>>>> On 2023/01/05 20:21:03 Julian Hyde wrote: >>>>>>>>>> Good idea. I have started reviewing those two cases. >>>>>>>>>> >>>>>>>>>> Reviewers are still needed for the other cases. >>>>>>>>>> >>>>>>>>>> Julian >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> >>>>>>>>>>> On Jan 5, 2023, at 3:39 AM, Dmitry Sysolyatin < >>>>>>>> dm.sysolya...@gmail.com> >>>>>>>>> wrote: >>>>>>>>>>> >>>>>>>>>>> It will be also good to review and include to release >>>>>>>>>>> https://issues.apache.org/jira/browse/CALCITE-5405 and >>>>>>>>>>> https://issues.apache.org/jira/browse/CALCITE-5407. I am not >>>>>>>> familiar >>>>>>>>> with >>>>>>>>>>> mongodb adapter >>>>>>>>>>> >>>>>>>>>>> On Thu, Jan 5, 2023 at 12:24 PM Stamatis Zampetakis < >>>>>>>> zabe...@gmail.com >>>>>>>>>> >>>>>>>>>>> wrote: >>>>>>>>>>> >>>>>>>>>>>> I added https://issues.apache.org/jira/browse/CALCITE-2884 >>> to the >>>>>>>>> list. I >>>>>>>>>>>> am finalizing the patch right now and will get this in a few >>>>> hours. >>>>>>>>>>>> I removed the fixVersion from >>>>>>>>>>>> https://issues.apache.org/jira/browse/CALCITE-5427 (I am >>> working >>>>> on >>>>>>>>> it) >>>>>>>>>>>> since there is no rush to get it in 1.33.0. >>>>>>>>>>>> Unfortunately, I don't have time to review other things >> today. >>>>>>>>>>>> >>>>>>>>>>>> Best, >>>>>>>>>>>> Stamatis >>>>>>>>>>>> >>>>>>>>>>>> On Wed, Jan 4, 2023 at 9:19 PM Julian Hyde < >>>>> jhyde.apa...@gmail.com> >>>>>>>>> wrote: >>>>>>>>>>>> >>>>>>>>>>>>> According to the dashboard [ >>>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>> >>>>>>>> >>>>> >>> >> https://issues.apache.org/jira/secure/Dashboard.jspa?selectPageId=12333950 >>>>>>>>>>>>> < >>>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>> >>>>>>>> >>>>> >>> >> https://issues.apache.org/jira/secure/Dashboard.jspa?selectPageId=12333950 >>>>>>>>>>>>> >>>>>>>>>>>>> ] there are 6 open issues, all of which have pull requests. >>>>>>>>>>>>> >>>>>>>>>>>>> Can we have volunteers to review/merge these in the next 24 >>>>> hours? >>>>>>>> As >>>>>>>>>>>> last >>>>>>>>>>>>> time, I’ll match: if 2 people take 2 issues each, I’ll take >>> the >>>>>>>> last >>>>>>>>> 2. >>>>>>>>>>>>> >>>>>>>>>>>>> Julian >>>>>>>>>>>>> >>>>>>>>>>>>> >>>>>>>>>>>>> >>>>>>>>>>>>> >>>>>>>>>>>>>> On Jan 4, 2023, at 11:30 AM, Jess Balint < >> jbal...@gmail.com >>>> >>>>>>>> wrote: >>>>>>>>>>>>>> >>>>>>>>>>>>>> Happy New Year everyone! I am going to do a RC build this >>> week >>>>> if >>>>>>>>> there >>>>>>>>>>>>> are >>>>>>>>>>>>>> no objections. >>>>>>>>>>>>>> >>>>>>>>>>>>>> On Thu, Dec 15, 2022 at 5:27 PM Bertil Chapuis < >>>>>>>> bchap...@gmail.com> >>>>>>>>>>>>> wrote: >>>>>>>>>>>>>> >>>>>>>>>>>>>>> Hello Everyone, >>>>>>>>>>>>>>> >>>>>>>>>>>>>>> I just merged CALCITE-5417 after incorporating Julian's >>>>>>>> feedback. I >>>>>>>>>>>>>>> believe this was the final issue that needed to be >> resolved >>>>>>>> before >>>>>>>>> the >>>>>>>>>>>>>>> release. >>>>>>>>>>>>>>> >>>>>>>>>>>>>>> Thanks a lot to Grigory for his help and for releasing >> new >>>>>>>>> versions of >>>>>>>>>>>>>>> proj4j early and often. >>>>>>>>>>>>>>> >>>>>>>>>>>>>>> Best, >>>>>>>>>>>>>>> Bertil >>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> On 15 Dec 2022, at 09:32, Ruben Q L <rube...@gmail.com> >>>>> wrote: >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> @Jess I think we should wait for [1], which is a cleaner >>>>>>>> solution >>>>>>>>> for >>>>>>>>>>>>> the >>>>>>>>>>>>>>>> Proj4j issue, better than the initial quick-fix that was >>>>>>>> committed >>>>>>>>>>>> some >>>>>>>>>>>>>>>> days ago [2]. >>>>>>>>>>>>>>>> The PR seems in a good shape (thanks Bertil and Julian >> for >>>>> your >>>>>>>>> work >>>>>>>>>>>> in >>>>>>>>>>>>>>>> this one!), and hopefully it will be merged soon. >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> @Sean, no, at this moment there's no plan for Avatica >> 1.23 >>>>>>>> release >>>>>>>>>>>> yet >>>>>>>>>>>>>>> (so >>>>>>>>>>>>>>>> it will not be included in Cacite 1.33). >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> Best, >>>>>>>>>>>>>>>> Ruben >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> [1] https://issues.apache.org/jira/browse/CALCITE-5417 >>>>>>>>>>>>>>>> [2] https://issues.apache.org/jira/browse/CALCITE-5399 >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> On Thu, Dec 15, 2022 at 3:14 AM Sean Broeder < >>> s...@dremio.com >>>>>> >>>>>>>>>>>> wrote: >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>> Are there plans to release a new version of >>> Avatica(1.23) to >>>>>>>> be >>>>>>>>>>>>>>> included >>>>>>>>>>>>>>>>> in Calcite 1.33.0? >>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>> Thanks, >>>>>>>>>>>>>>>>> Sean >>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>> On Dec 14, 2022, at 3:47 PM, Jess Balint < >>> jbal...@gmail.com >>>>>> >>>>>>>>>>>> wrote: >>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>> I have reviewed a few PRs. The Proj4j fix has been >>> merged. >>>>> Do >>>>>>>> we >>>>>>>>>>>> have >>>>>>>>>>>>>>> any >>>>>>>>>>>>>>>>>> more bandwidth for reviews or anybody asking for >>> reviews? >>>>>>>>>>>> Otherwise, >>>>>>>>>>>>> I >>>>>>>>>>>>>>>>> can >>>>>>>>>>>>>>>>>> start the RC build soon. >>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>> On Mon, Nov 28, 2022 at 6:07 AM Ruben Q L < >>>>> rube...@gmail.com> >>>>>>>>>>>> wrote: >>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>> Thanks Jess for being RM of 1.33, and thanks Benchao >>> for >>>>>>>>>>>>> volunteering >>>>>>>>>>>>>>> as >>>>>>>>>>>>>>>>>>> RM. >>>>>>>>>>>>>>>>>>> The updated list for future releases will be as >>> follows: >>>>>>>>>>>>>>>>>>> - 1.33.0 Jess Balint >>>>>>>>>>>>>>>>>>> - 1.34.0 Duan Xiong >>>>>>>>>>>>>>>>>>> - 1.35.0 Benchao Li >>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>> There are currently 14 unresolved issues for 1.33: >>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>> >>>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>> >>>>>>>> >>>>> >>> >> https://issues.apache.org/jira/secure/Dashboard.jspa?selectPageId=12333950 >>>>>>>>>>>>>>>>>>> Many of them have a PR available, let's try to do a >>>>>>>> collective >>>>>>>>>>>>> effort >>>>>>>>>>>>>>>>> and >>>>>>>>>>>>>>>>>>> review them ASAP (I remind everyone that you can >>> assign a >>>>> PR >>>>>>>> to >>>>>>>>>>>>>>>>> yourself to >>>>>>>>>>>>>>>>>>> let others know that you are taking care of it). >>>>>>>>>>>>>>>>>>> As I mentioned on the initial email, let's try to >>> finalize >>>>>>>> the >>>>>>>>>>>>>>> remaining >>>>>>>>>>>>>>>>>>> issues during these two weeks, to see if we can >>> produce a >>>>> RC0 >>>>>>>>> by >>>>>>>>>>>>>>>>>>> mid-December. >>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>> Regarding the recent Proj4j license problem ( >>>>>>>>>>>>>>>>>>> https://issues.apache.org/jira/browse/CALCITE-5399), >>>>> should >>>>>>>> we >>>>>>>>>>>>>>> consider >>>>>>>>>>>>>>>>>>> this a blocking issue for 1.33? >>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>> Best, >>>>>>>>>>>>>>>>>>> Ruben >>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>> On Fri, Nov 11, 2022 at 6:53 PM Jess Balint < >>>>>>>> jbal...@gmail.com >>>>>>>>>> >>>>>>>>>>>>>>> wrote: >>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>>> Hi Ruben, >>>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>>> Thanks for the note. I'm available for RM duty. >>> Here's the >>>>>>>>> list >>>>>>>>>>>> of >>>>>>>>>>>>>>>>> issues >>>>>>>>>>>>>>>>>>>> currently outstanding: >>>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>> >>>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>> >>>>>>>> >>>>> >>> >> https://issues.apache.org/jira/issues/?jql=project%20%3D%20CALCITE%20AND%20fixVersion%20%3D%201.33.0%20AND%20status%20in%20(Open%2C%20%22In%20Progress%22%2C%20%22In%20Review%22%2C%20%22In%20Implementation%22)%20ORDER%20BY%20priority%20DESC >>>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>>> I'll pick up a couple of reviews and see if we can >>> move >>>>> out >>>>>>>>> some >>>>>>>>>>>> of >>>>>>>>>>>>>>> the >>>>>>>>>>>>>>>>>>>> issues which haven't been started yet. >>>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>>> Jess >>>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>>> On Fri, Nov 11, 2022 at 3:20 AM Ruben Q L < >>>>>>>> rube...@gmail.com> >>>>>>>>>>>>> wrote: >>>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>>>> Hello, >>>>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>>>> It's been two months since our last release [1], if >>> we >>>>> want >>>>>>>>> to >>>>>>>>>>>>> keep >>>>>>>>>>>>>>>>> our >>>>>>>>>>>>>>>>>>>>> rhythm, I'd suggest to produce the next one before >>> the >>>>> end >>>>>>>> of >>>>>>>>>>>> the >>>>>>>>>>>>>>>>> year. >>>>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>>>> As usual, according to our Jira dashboard [2] and >>> Github >>>>>>>> [3], >>>>>>>>>>>>> there >>>>>>>>>>>>>>>>> are >>>>>>>>>>>>>>>>>>>>> many pending issues that could / should be part of >>> the >>>>>>>>> release. >>>>>>>>>>>>> I'd >>>>>>>>>>>>>>>>>>>> propose >>>>>>>>>>>>>>>>>>>>> to make a collective effort to try to clean up our >>> 1.33 >>>>>>>>> backlog >>>>>>>>>>>>> and >>>>>>>>>>>>>>>>>>> merge >>>>>>>>>>>>>>>>>>>>> the PRs which are in a good state. Shall we give >>>>> ourselves >>>>>>>>>>>> around >>>>>>>>>>>>>>> four >>>>>>>>>>>>>>>>>>>>> weeks and aim at approximately December 11th for >> the >>>>> first >>>>>>>>> RC? >>>>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>>>> According to this thread [4], the list of the last >>>>> Release >>>>>>>>>>>>> Managers >>>>>>>>>>>>>>> is >>>>>>>>>>>>>>>>>>> as >>>>>>>>>>>>>>>>>>>>> follows: >>>>>>>>>>>>>>>>>>>>> - 1.30.0 Liya Fan >>>>>>>>>>>>>>>>>>>>> - 1.31.0 Andrei Sereda >>>>>>>>>>>>>>>>>>>>> - 1.32.0 Julian Hyde (originally Jess Balint, >>> switched >>>>> with >>>>>>>>>>>> 1.33) >>>>>>>>>>>>>>>>>>>>> --- >>>>>>>>>>>>>>>>>>>>> - 1.33.0 Jess Balint (originally Julian Hyde, >>> switched >>>>> with >>>>>>>>>>>> 1.32) >>>>>>>>>>>>>>>>>>>>> - 1.34.0 Duan Xiong >>>>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>>>> @Jess, are you still available to be the next RM >> for >>>>>>>> 1.33.0? >>>>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>>>> Do we have any other volunteers to be RM for the >> next >>>>>>>>> releases? >>>>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>>>> Best regards, >>>>>>>>>>>>>>>>>>>>> Ruben >>>>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>>>> [1] >>>>>>>>> https://calcite.apache.org/news/2022/09/10/release-1.32.0/ >>>>>>>>>>>>>>>>>>>>> [2] >>>>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>> >>>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>> >>>>>>>> >>>>> >>> >> https://issues.apache.org/jira/secure/Dashboard.jspa?selectPageId=12333950 >>>>>>>>>>>>>>>>>>>>> [3] https://github.com/apache/calcite/pulls >>>>>>>>>>>>>>>>>>>>> [4] >>>>>>>>>>>>>>> >>>>> https://lists.apache.org/thread/ykbhhxmljw6wg50rxs6ypp35173hlkdv >>>>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>> >>>>>>>>>>>>>>> >>>>>>>>>>>>> >>>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>> >>>>>>>>>> >>>>>>>>> >>>>>>>> >>>>> >>> >>
