Julian,
Thanks for taking time, and working on this.
"Fixture" is a too broad term, and I do not mean we should replace it
completely with AssertJ.
What I mean is that AssertJ allows creating *discoverable* assertions.
Hamcrest assertions are hard to create and hard to discover in IDE.
---
Re test code implementations, we junit5 extensions would likely be useful.
For instance
@ExtendWith(CalciteParserExtensions.class)
@WithLex(BACK_TICKS)
class MyParserTest {
void invalidSqlFails(SqlParserFixture sql) { // <-- injected by extension
.....
In other words, it does not mean fixture (whatever it means) must be 100%
junit5.
What I mean, junit5 extensions could simplify writting calcite tests by
making fixture confuguration declarative, and injecting the configured
object as test method argument.
Vladimir
