Agree with Jiatao, I had the same experience and feeling. But it mainly depends on the rule creator's preference.
On 2020/11/23 02:42:21, Danny Chan <danny0...@apache.org> wrote: > I kind of agree, but it's more like a programming specification, we can > tell people how to write codes but they may not follow those rules. > > JiaTao Tao <taojia...@gmail.com> 于2020年11月22日周日 下午5:27写道： > > > Why I don't want to debug into "transformTo": > > > > 1. It's a common method, if you directly stop here, every rule will stop, > > or you must stop the specific rule, then step into this method call, it's > > one more step. > > 2. There are many contexts in the rule, if you debug into "transformTo", > > you have to go back to see these. > > > > > > Regards! > > > > Aron Tao > > > > > > JiaTao Tao <taojia...@gmail.com> 于2020年11月22日周日 下午5:23写道： > > > > > Hi > > > I've been developed Calcite full time for a quite long time, and I ofter > > > debug in the rule to see the transformations, but code like this is not > > > debuging friendly in my opinion: "call.transformTo(relBuilder.build())" > > > > > > I want to see the relBuilder.build()'s result, I have to debug into the > > > "transformTo" method(you can not evaluate "relBuilder.build()" cuz it's a > > > stack), if we split this into two lines, we can just stop at the last > > link: > > > > > > RelNode ret = relBuilder.build() > > > call.transformTo(ret) > > > > > > It's not a big deal, but every time I occur this, it has poor > > experience, hope > > > to hear the community's opinion. > > > > > > Regards! > > > > > > Aron Tao > > > > > >
