+1 (non-binding) - check sha512 OK - check gpg signature OK (last timely I forgot to import calcite KEYS locally, sorry about that) - ./gradlew build OK - check the rc3 tag with right commit OK - compare git tag files with files extracted from artifacts, There is a difference about LICENSE file. Also the artifact has one extra "licenses" directory . By reading the diff I think it is still OK. (Also it should be a known case that appeared in a past release) - Tested the artifact with Apache Beam. There are breaks but none is regression (e.g. break due to some API evolutions, which is understandable). OK
-Rui On Mon, Mar 2, 2020 at 2:10 PM Francis Chuang <[email protected]> wrote: > My vote is +1 (binding) > > Thanks for making this rc available for voting, Danny! > > Checked GPG signature - OK > Checked hash - OK > Ran tests per HOWTO (./gradlew check) - OK > Release notes (quick skim) - OK > Maven artifacts (spot checked a few files on nexus) - OK > > Environment (gradle:latest docker container): > Gradle 6.1.1 (via gradlew) > Ubuntu 18.04.4 LTS > openjdk version "1.8.0_232" > OpenJDK Runtime Environment (AdoptOpenJDK)(build 1.8.0_232-b09) > OpenJDK 64-Bit Server VM (AdoptOpenJDK)(build 25.232-b09, mixed mode) > > Great work, Danny! > > My reasons for voting +1: > - This release is overdue and since we are at rc3 already, this is > probably causing the RM a lot of release fatigue. I've been RM for a few > releases where a lot of RCs were created and it's discouraging to have > another rc rejected and having to go back and build another one. > > - This is a pretty big release and there endless improvements and bugs > that can be added to this release. We should get this release out and > aim for the next release to clean up these regressions. > > - CALCITE-3839 is a regression, but as this release is already quite > delayed and we are planning to make the next release (1.23.0) available > soon after this release, it's possible to skip this release and wait for > the next one. > > - I'd suggest adding a daily job in CI that integrates with Calcite > master to catch regressions such as CALCITE-3839. > > > On 3/03/2020 12:28 am, Danny Chan wrote: > > Hi all, > > > > I have created a build for Apache Calcite 1.22.0, release > > candidate 3. > > > > Thanks to everyone who has contributed to this release. > > > > You can read the release notes here: > > https://github.com/apache/calcite/blob/v1.22.0-rc3/site/_docs/history.md > > > > The commit to be voted upon: > > > https://gitbox.apache.org/repos/asf?p=calcite.git;a=commit;h=537b8dbb4b58c61b6c573eb07a51b8d38896a1ff > > > > Its hash is 537b8dbb4b58c61b6c573eb07a51b8d38896a1ff > > > > Tag: > > https://github.com/apache/calcite/tree/v1.22.0-rc3 > > > > The artifacts to be voted on are located here: > > https://dist.apache.org/repos/dist/dev/calcite/apache-calcite-1.22.0-rc3 > > (revision 38350) > > > > The hashes of the artifacts are as follows: > > > a7dface824287756fcc66f6f075286975e409e7ea9a0af97ad973f90bc2832250c09e0477bc571bd78f6ee3721883cce76cada9a3e9601e1dd497fb02679647f > > *apache-calcite-1.22.0-src.tar.gz > > > > A staged Maven repository is available for review at: > > > https://repository.apache.org/content/repositories/orgapachecalcite-1080/org/apache/calcite/ > > > > Release artifacts are signed with the following key: > > https://people.apache.org/keys/committer/danny0405.asc > > https://www.apache.org/dist/calcite/KEYS > > > > N.B. > > To create the jars and test Apache Calcite: "./gradlew build". > > > > If you do not have a Java environment available, you can run the tests > > using docker. To do so, install docker and docker-compose, then run > > "docker-compose run test" from the root of the directory. > > > > Please vote on releasing this package as Apache Calcite 1.22.0. > > > > The vote is open for the next 72 hours and passes if a majority of at > > least three +1 PMC votes are cast. > > > > [ ] +1 Release this package as Apache Calcite 1.22.0 > > [ ] 0 I don't feel strongly about it, but I'm okay with the release > > [ ] -1 Do not release this package because... > > > > > > Here is my vote: > > > > +1 (binding) > > > > Best, > > Danny Chan > > >
