With the help of Stamatis we have created a reproducer the attached test case (in the last comment) fails on current master (and 1.22.0rc) but does not fail on 1.21 so it can be considered a real regression
Stamatis created a test case for Calcite code base, that can be used by a developer to fix the issue https://issues.apache.org/jira/browse/CALCITE-3826 I am sorry I am not able to work on it these days Enrico Il giorno gio 27 feb 2020 alle ore 09:29 Julian Hyde <jhyde.apa...@gmail.com> ha scritto: > > Danny > > I agree that a -1 is disheartening. Especially when given for mistaken > reasons. > > Technically a -1 does not kill an RC. We just need 3 more +1 votes than -1 > votes. > > I urge everyone to give detailed rationale for their vote. Even if you vote > +1, describe what you checked. > > Julian > > > On Feb 26, 2020, at 03:14, Danny Chan <yuzhao....@gmail.com> wrote: > > > > Gives a -1 when you are sure that it is a bug, or the voting would be very > > depressing, anyone can give a -1 for any reasons. > > > > Best, > > Danny Chan > > 在 2020年2月26日 +0800 PM3:04，Enrico Olivelli <eolive...@gmail.com>，写道： > >> Danny, > >> I have created https://issues.apache.org/jira/browse/CALCITE-3826 > >> for the problem about bind variables in UPDATE statements. > >> > >> I feel this it can be a serious regression that can lead to data > >> corruption (wrong data type in DML statements). > >> AFAICT There is no way to workaround the problem in the application, > >> because Calcite produces a wrong model for the query. > >> > >> It seems to be a regression introduced in > >> https://issues.apache.org/jira/browse/CALCITE-3672 but I am not sure. > >> we should confirm the bug and fix it or demonstrate that the bug is not > >> valid > >> > >> -1 (non binding) > >> > >> Enrico > >> > >>> Il giorno mer 26 feb 2020 alle ore 07:34 Feng Zhu > >>> <wellfeng...@gmail.com> ha scritto: > >>> > >>> Hi Danny, > >>> Thanks for your efforts. > >>> > >>> +1 (non-binding) > >>> > >>> Environment: Windows 7, JDK 1.8.0_121 > >>> - Build and Test (./gradlew build) - OK > >>> - Checked Release Notes - OK > >>> - Checked README - OK > >>> > >>> Best, > >>> Feng > >>> > >>> Danny Chan <yuzhao....@gmail.com> 于2020年2月26日周三 下午1:23写道： > >>> > >>>> Hi all, > >>>> > >>>> I have created a build for Apache Calcite 1.22.0, release candidate 2. > >>>> > >>>> Thanks to everyone who has contributed to this release. > >>>> <Further details about release.> You can read the release notes here: > >>>> https://github.com/apache/calcite/blob/calcite-1.22.0/site/_docs/history.md > >>>> > >>>> The commit to be voted upon: > >>>> > >>>> https://gitbox.apache.org/repos/asf?p=calcite.git;a=commit;h=e397e47b0752c0647590097584903a9561a646eb > >>>> > >>>> Its hash is e397e47b0752c0647590097584903a9561a646eb. > >>>> > >>>> The artifacts to be voted on are located here: > >>>> https://dist.apache.org/repos/dist/dev/calcite/apache-calcite-1.22.0-rc2/ > >>>> > >>>> The hashes of the artifacts are as follows: > >>>> src.tar.gz.sha512 > >>>> > >>>> 049a7650645106589b8fa65adf36ebbe90accf8359bcc05f40d7b50b00df9327b24b189c4cd1c0e12a702635cc1dc41f9e8b60238073bf83dfcff9c0ef60e66a > >>>> *apache-calcite-1.22.0-src.tar.gz > >>>> > >>>> A staged Maven repository is available for review at: > >>>> https://repository.apache.org/content/repositories/orgapachecalcite-1079 > >>>> > >>>> Release artifacts are signed with the following key: > >>>> https://people.apache.org/keys/committer/danny0405.asc > >>>> > >>>> Please vote on releasing this package as Apache Calcite 1.22.0. > >>>> > >>>> The vote is open for the next 72 hours and passes if a majority of > >>>> at least three +1 PMC votes are cast. > >>>> > >>>> [ ] +1 Release this package as Apache Calcite 1.22.0 > >>>> [ ] 0 I don't feel strongly about it, but I'm okay with the release > >>>> [ ] -1 Do not release this package because... > >>>> > >>>> Here is my vote: > >>>> > >>>> +1 (binding) > >>>> > >>>> Best, > >>>> Danny Chan > >>>>
