Hello, I like the idea of adding more tests but I am also afraid of having many false positives.
I was under the impression that some kind of rules should always be executed in a certain way. For instance, implementation rules (Logical -> Enumerable) should always go top-down so that trait demand works correctly. As it came up other projects may indeed write rules that they rely on a particular order of executing the rules for having an executable plan so in the end I am not sure if the randomization will help a lot. I didn't thoroughly think on it so I am leaving the decision up to Vladimir. Best, Stamatis On Sat, Jan 11, 2020 at 9:39 PM Vladimir Sitnikov < [email protected]> wrote: > Michael>I'm not sure I see how the property > Michael>for passing tests with different plans would work > > E.g. @Tag("skipWhenRandomizedRules") and CalciteAssert#explainContains > could become a no-op when a special property is passed. > > Of course, the randomization should be for test purposes, not for > production. > > Vladimir >
