I'm not sure why you assume I don't know what checks are there. In any case, I was referring to your own comment on the PR which indicated two missing checks. Compiling the plugin before running checkstyle doesn't sound too painful, but I'm not really familiar with Gradle/Kotlin. -- Michael Mior [email protected]
Le jeu. 5 déc. 2019 à 06:13, Vladimir Sitnikov <[email protected]> a écrit : > > Michael> -0 because I haven't found checkstyle violations > Michael> and I don't like the idea of losing checks which are currently in > Michael> place > > Would you please re-evaluate? I seems like you did not know which checks > are there and which are not. > > To my best knowledge, the only missing check is "Javadoc line too long ({0} > chars)". > However, Checkstyle already has "Line is longer than 100 characters" > warning, so I see no reasons why > extra javadoc-related check is needed. > > All the rest are there, and most of the checks are strictly better now. > > Can we just commit it and move forward? > > Vladimir
