I see that this feature request relates to Source.java and Sources.java, which are in org.apache.calcite.util in core.
If you add some capability, it is fine to add It to the CSV adapter example, but it is much more important that that capability exists in the file adapter. Julian > On Nov 14, 2019, at 11:36 AM, Andrei Sereda <[email protected]> wrote: > > I think the change is straightforward (will not add complexity). > > On Thu, Nov 14, 2019 at 1:24 PM Julian Hyde <[email protected]> wrote: > >> Remember that CsvAdapter is in the “example” module. Keep it simple. >> >> The file adapter can also parse CSV files. >> >> Julian >> >> >> >>> On Nov 14, 2019, at 9:40 AM, Andrei Sereda <[email protected]> wrote: >>> >>> Hello, >>> >>> Source object already exposes Reader / InputStream API. Probably >>> JsonEnumerator can be changed to use those methods. >>> >>> Do you mind creating a JIRA ticket ? I'll take a look. >>> >>> Thanks, >>> Andrei. >>> >>> On Thu, Nov 14, 2019 at 7:45 AM Yanna elina <[email protected]> >>> wrote: >>> >>>> Hi guys , >>>> I saw in the code that this nice adapter makes it possible to make SQL >>>> queries on the data JSON >>>> >>>> >> https://github.com/apache/calcite/tree/ab71c4cae5a5c3c7d979337a2d38ddaf271aa206/example/csv/src/main/java/org/apache/calcite/adapter/csv >>>> >>>> But it's limited on File / URL. >>>> JsonTable constructor accepte only a Source object and this Source >> object >>>> can be construct only accross a File / URL. >>>> >>>> it could be nice to have the possibility to make this source from >>>> ImputStream too . >>>> >>>> Creating a temp-file from an InputStream or String can be excesive. >>>> >>>> Thanks >>>> >> >>
