I've added back the names and I'm redeploying the site now. I think I've said this before, but I don't really see the point of adding contributor names into commit messages when they are already recorded as the author of the commit. If the commit needs to be edited or rebased, the author can be preserved.
If we want to keep names in release notes, we could script things to pull the commit author to generate a first draft of the release notes. Really, I think such a script should exist anyway since putting together the release notes can be rather tedious. -- Michael Mior [email protected] Le lun. 24 juin 2019 à 20:13, Julian Hyde <[email protected]> a écrit : > > In my opinion, we should add back the names to 1.20’s release notes. > > For further releases (and future commits), I’m happy to have a discussion > about our policy of adding names of non-committer contributors to commit > messages and release notes. It is, after all, somewhat unusual and rather > onerous. I can see both sides of the issue, so I would not object if we kept > the current policy or if we changed it. > > Julian > > > > On Jun 24, 2019, at 1:28 PM, Michael Mior <[email protected]> wrote: > > > > I think the rotation is working out alright except that it's a > > challenging sticking to a time-based schedule. > > > > As far as the release notes, you're correct that I generated these > > from the commit log. I actually intentionally stripped out the names > > since at the time they felt like noise. I'll acknowledge now that I > > think that was a poor decision. It wasn't done with the desire for > > people not be recognized as Calcite certainly wouldn't be where it is > > without these contributions. > > > > I'll happily retroactively update these to add back the names in the > > next day or two. A big thank you to all who contributed to the release > > especially those who are not currently committers and do not have much > > acknowledgement right now :) > > > > -- > > Michael Mior > > [email protected] <mailto:[email protected]> > > > > Le lun. 24 juin 2019 à 14:10, Julian Hyde <[email protected] > > <mailto:[email protected]>> a écrit : > >> > >> Just back for vacation... and it’s great to see a shiny new release. Thank > >> you, Michael, for getting it out of the door. > >> > >> Release management is a huge task these days. A few months ago [1] we > >> agreed a rotation of release managers for a few releases ahead. I think > >> this is working well; it makes sure that the work is spread among several > >> people, and it also provides an incentive to get each release out early. > >> (If, as release manager, you procrastinate, then the task gets larger.) > >> > >> How do people feel the rotating release manager schedule is working out? > >> > >> Someone else remarked that the release notes are missing the names of > >> non-committer contributors. I think we should edit the release notes > >> retrospectively to include these names. Calling out new contributors makes > >> them want to stick around, do more, and eventually earn committer status. > >> > >> Michael, How did you generate the release notes? It looks as if you > >> generated them from the commit log, not the JIRA cases - which is the > >> right thing - but somehow those names got stripped. > >> > >> Julian > >> > >> [1] > >> https://lists.apache.org/thread.html/c6fba3f6585139ba6919baf71835d32eeea8ca187621aa5c06a26f8c@%3Cdev.calcite.apache.org%3E > >> > >> <https://lists.apache.org/thread.html/c6fba3f6585139ba6919baf71835d32eeea8ca187621aa5c06a26f8c@%3Cdev.calcite.apache.org%3E><https://lists.apache.org/thread.html/c6fba3f6585139ba6919baf71835d32eeea8ca187621aa5c06a26f8c@%3Cdev.calcite.apache.org%3E > >> > >> <https://lists.apache.org/thread.html/c6fba3f6585139ba6919baf71835d32eeea8ca187621aa5c06a26f8c@%3Cdev.calcite.apache.org%3E>> >
