Thanks for being RM for this massive release, Michael!
Checked GPG signature - OK
Checked hash - OK
Ran tests per HOWTO (./mvnw -DskipTests clean install and ./mvnw test) -OK
Release notes - OK
Had a quick look at the maven artifacts and everything seems to be in
place - OK
Environment (in Docker maven:latest container):
Debian GNU/Linux 9 (stretch)
openjdk 11.0.3 2019-04-16
OpenJDK Runtime Environment 18.9 (build 11.0.3+7)
OpenJDK 64-Bit Server VM 18.9 (build 11.0.3+7, mixed mode)
Just 2 small things:
Checking the contents of core/pom.xml and comparing it to the changes on
git, I think the commit to be voted on is
31a3321a23e995e6c7bdc7f4be5dbee275c5a61f and not
3979b460c3a39024883d2378b9bcac9599efc61e.
The key at https://people.apache.org/keys/committer/mmior.asc appears to
be your older key which was not used to sign this release, so I think it
should be updated to your newer key.
Thanks again, Michael!
+1 (binding)
Francis
On 20/06/2019 4:44 am, Michael Mior wrote:
Hi all,
I have created a build for Apache Calcite 1.20.0, release candidate 0.
Thanks to everyone who has contributed to this release.
We've got support for anti-joins, recursive queries, new functions,
support for recursive queries in the relational algebra, a new
adapter, and more! You can read the release notes here:
https://github.com/apache/calcite/blob/calcite-1.20.0/site/_docs/history.md
The commit to be voted upon:
https://gitbox.apache.org/repos/asf?p=calcite.git;a=commit;h=3979b460c
Its hash is 3979b460c3a39024883d2378b9bcac9599efc61e.
The artifacts to be voted on are located here:
https://dist.apache.org/repos/dist/dev/calcite/apache-calcite-1.20.0-rc0/
The hashes of the artifacts are as follows:
src.tar.gz.sha256
9c2b408e7a9bfc7b60b34cd61cf6649cb6d17b21f44b4799d52e118ec69471e8
A staged Maven repository is available for review at:
https://repository.apache.org/content/repositories/orgapachecalcite-1061
Release artifacts are signed with the final key listed in the following URL:
https://dist.apache.org/repos/dist/release/calcite/KEYS
This key should also be available tomorrow at the URL below once the
job which updates the published keys runs.
https://people.apache.org/keys/committer/mmior.asc
Please vote on releasing this package as Apache Calcite 1.20.0.
The vote is open for the next 72 hours and passes if a majority of
at least three +1 PMC votes are cast.
[ ] +1 Release this package as Apache Calcite 1.20.0
[ ] 0 I don't feel strongly about it, but I'm okay with the release
[ ] -1 Do not release this package because...
Here is my vote:
+1 (binding)
Michael
