hsyuan commented on a change in pull request #1048: [CALCITE-2722] Rewrite
createLeftCall in iterative way instead of recursive way
URL: https://github.com/apache/calcite/pull/1048#discussion_r260093386
##########
File path:
core/src/main/java/org/apache/calcite/rel/rel2sql/SqlImplementor.java
##########
@@ -748,13 +747,14 @@ private SqlNode createSqlWindowBound(RexWindowBound
rexWindowBound) {
}
private SqlNode createLeftCall(SqlOperator op, List<SqlNode> nodeList) {
- if (nodeList.size() == 2) {
- return op.createCall(new SqlNodeList(nodeList, POS));
+ assert nodeList != null && nodeList.size() >= 2;
Review comment:
Just notice your comments, sorry for being late.
Thanks for your review, I will take care for future PRs.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
