nerrve commented on a change in pull request #1043: [CALCITE-2552] : Support
for column alias in order by clause for BigQuerySqlDialect and HiveSqlDialect
URL: https://github.com/apache/calcite/pull/1043#discussion_r258461861
##########
File path:
core/src/test/java/org/apache/calcite/rel/rel2sql/RelToSqlConverterTest.java
##########
@@ -142,6 +142,52 @@ private static String toSql(RelNode root, SqlDialect
dialect) {
return sqlNode.toSqlString(dialect).getSql();
}
+ @Test public void testSimpleSelectWithOrderByAliasDescNullsFirst() {
Review comment:
We already have similar tests such as
"testHiveSelectQueryWithOrderByAscAndNullsLastShouldBeEmulated". You can add
your expectations there
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
