kgyrtkirk commented on a change in pull request #1048: [CALCITE-2722] Rewrite
createLeftCall in iterative way instead of recursive way
URL: https://github.com/apache/calcite/pull/1048#discussion_r257963315
##########
File path:
core/src/main/java/org/apache/calcite/rel/rel2sql/SqlImplementor.java
##########
@@ -751,10 +750,14 @@ private SqlNode createLeftCall(SqlOperator op,
List<SqlNode> nodeList) {
if (nodeList.size() == 2) {
Review comment:
I think we may also drop this "== 2" specialization as the method is no
longer recursive
+1
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
