danny0405 commented on a change in pull request #1044: [CALCITE-2838]
Simplification: Remove redundant IS TRUE/IS NOT FALSE …
URL: https://github.com/apache/calcite/pull/1044#discussion_r257457260
##########
File path:
core/src/test/java/org/apache/calcite/test/fuzzer/RexProgramFuzzyTest.java
##########
@@ -262,11 +262,12 @@ private void checkUnknownAs(RexNode node, RexUnknownAs
unknownAs) {
}
}
}
- if (opt.getType().isNullable() && !node.getType().isNullable()) {
+ if (unknownAs == RexUnknownAs.UNKNOWN
+ && opt.getType().isNullable()
Review comment:
This means a simplified node may change nullability if RexUnknownAs is not
UNKNOWN，during planner node transformation, sometimes we need all the node
types must be equal including nullability, e.g. VolcanoPlanner RelSubsets, what
do you think about this ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
