vlsi commented on a change in pull request #1042: Avoid use of new
RuntimeException(e) in tests
URL: https://github.com/apache/calcite/pull/1042#discussion_r256849041
##########
File path:
core/src/test/java/org/apache/calcite/sql/test/SqlOperatorBaseTest.java
##########
@@ -8153,7 +8154,7 @@ public TesterImpl(SqlTestFactory testFactory) {
} catch (RuntimeException e) {
throw e;
Review comment:
That's true, it should be removed. I just did a global search and replace,
and I did not verify the individual cases.
It seems to be the only entry in test code for `catch \(RuntimeException
\w+\) \{\s*throw` regexp.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
