Configuring checkstyle IntelliJ's plugin keeps showing errors while attempting to compile the *src/main/config/checkstyle/checker.xml* file.
First, it complained it couldn't find the *FileContentsHolder* module, which turns out to have been renamed to *FileHolder*. Second, it required moving the *SuppressionCommentFilter* and *SuppressWithNearbyCommentFilter* modules beneath the *TreeWalker* module. Third, it complained about a missing module: *net.hydromatic.toolbox.checkstyle.HydromaticFileSetCheck*. Should I pick a different checkstyle version instead ? If this is the right path to take, how can I resolve the missing module problem ? Thanks, Gelbana On Mon, Mar 26, 2018 at 2:58 PM, Michael Mior <[email protected]> wrote: > Currently, we only have published guides for IntelliJ and NetBeans which > you can find here > > https://calcite.apache.org/docs/howto.html#setting-up-an- > ide-for-contributing > > -- > Michael Mior > [email protected] > > 2018-03-25 16:33 GMT-04:00 Muhammad Gelbana <[email protected]>: > > > Is the Eclipse IDE setup guide complete somewhere ? I couldn't find it on > > the web and after following the guides in this thread, I still face > > numerous build errors in Eclipse. > > > > Thanks, > > Gelbana > > > > On Sat, Feb 10, 2018 at 12:56 AM, Edmon Begoli <[email protected]> > wrote: > > > > > Does anyone have a checkstyle file for Calcite for Eclipse to share via > > > gist, so we can include it as part of the instructions. > > > > > > Alternatively, is there an easy way to turn some or all checks off? > > > > > > It looks that project import is dying on checkstyle. > > > > > > On Thu, Feb 8, 2018 at 16:04 Julian Hyde <[email protected]> wrote: > > > > > > > Here is a suggestion for how to organize this. Avoid the temptation > to > > > > write a long list of instructions that anticipates everything that > can > > go > > > > wrong. Write a much shorter, simpler account that will work for 90% > of > > > > people 90% of the time. Then have a separate entry in the same HOWTO > > > > dealing with the many 10%s, e.g. “Why can my IDE not find > > > > ExtensionSqlParserImpl.java?” If someone is in the 10%, they will > find > > it > > > > easily when they search for the error message. > > > > > > > > In essence, this is case-based reasoning, and the howto is a > > > > knowledge-base of small (symptom, problem, solution) articles. > > > > > > > > > > > > > On Feb 8, 2018, at 12:41 PM, Edmon Begoli <[email protected]> > wrote: > > > > > > > > > > Good suggestions. > > > > > > > > > > I do think that some tools come with extra gotchas, so if we are to > > > lower > > > > > the barrier to entry for Calcite contribution, I would strive to > > > minimize > > > > > the struggles. > > > > > > > > > > I sort of taken this initiative on my own to help with a technical > > and > > > > > instruction writing. > > > > > IntelliJ tips I got were great, including pointers to the actual > > style > > > > > schemes, so that part is done. > > > > > NetBeans seems to be close too. (really easy to get started) > > > > > > > > > > It would be wonderful if experienced eclipse users could help me > > > assemble > > > > > the similar set of instructions, so that I could write a good > > "howto". > > > > > I could do it on my own, but it might take me a little bit longer > > with > > > > > "Trial and errors". > > > > > > > > > > Your suggestion about getting started with actual development is > > great. > > > > > Perhaps that would be a great, separate "howto". > > > > > > > > > > On Thu, Feb 8, 2018 at 3:14 PM, [email protected] < > > > [email protected] > > > > > > > > > > wrote: > > > > > > > > > >> First thing first - install maven as an external tool. Then point > > your > > > > >> Eclipse to use it.Just as the your looking results suggest :) > > > > >> > > > > >> My personal opinion about the case is that this is not the problem > > of > > > > >> setting up calcite with any IDE to have working > build/run/debug/test > > > > >> commands but rather effective using maven tool with IDE. So I > would > > > not > > > > >> document the project import procedure itself but rather the coding > > > > >> conventions used in Calcite and how to set them up in IDE, for > > example > > > > >> checkstyle rules or formatting. After few lines in Netnbeans IDE > > from > > > > very > > > > >> different development culture I know how it is painful to code few > > > > lines in > > > > >> Calcite in their own conventions. > > > > >> > > > > >> I would search some tutorials about using and importing maven > > projects > > > > into > > > > >> IDEs and point to them in Your contribution. Such solution should > > > lead > > > > >> developers to have more abstract notion where Calcite begins as a > > > coding > > > > >> project and where tools like maven have their responsibilities, > > > > especially > > > > >> when even few changed java lines in Calcite could lead to changes > in > > > > maven > > > > >> project descriptors (pom.xml files). Having that said I follow > with > > > > >> describing coding rules in Calcite - formatting and checkstyle > would > > > be > > > > the > > > > >> first. > > > > >> > > > > >> On Thu, Feb 8, 2018 at 6:23 PM Edmon Begoli <[email protected]> > > > wrote: > > > > >> > > > > >>> I am on Maven 3.5 and Eclipse Oxygen .2 > > > > >>> > > > > >>> I did mvn eclipse:eclipse. > > > > >>> > > > > >>> Then "open existing project -> open" Chose the specialized > imports > > > and > > > > >>> selected "Maven -> import maven project" and selected root > > directory > > > > >> name, > > > > >>> chose the Maven source. > > > > >>> > > > > >>> At the attempt of import, I got: > > > > >>> > > > > >>> No marketplace entries found to handle > > fmpp-maven-plugin:1.0:generate > > > > in > > > > >>> Eclipse. Please see Help for more information. > > > > >>> ... > > > > >>> No marketplace entries found to handle > > javacc-maven-plugin:2.4:javacc > > > > in > > > > >>> Eclipse. Please see Help for more information. > > > > >>> ... > > > > >>> No marketplace entries found to handle > > maven-clean-plugin:3.0.0:clean > > > > in > > > > >>> Eclipse. Please see Help for more information. > > > > >>> > > > > >>> By looking around, it looks like I would need to switch to > > external, > > > > and > > > > >>> not embedded Maven. > > > > >>> > > > > >>> Did not try that yet. > > > > >>> > > > > >>> Any suggestions? > > > > >>> > > > > >>> NOTE: I am doing this for the purpose of documenting the > repeatable > > > > setup > > > > >>> steps for contributing developers using different, popular IDEs. > > > > >>> > > > > >>> > > > > >>> On Thu, Feb 8, 2018 at 10:57 AM, Josh Elser < > [email protected]> > > > > >> wrote: > > > > >>> > > > > >>>> I've chased these down a few times on Avatica and other > projects. > > > > >>>> > > > > >>>> In general, you shouldn't have to invoke the eclipse:eclipse > mojo > > > > >>> directly > > > > >>>> to import to modern versions of Eclipse. You should just be able > > to > > > > >>> import > > > > >>>> it as a Maven project. If that fails, it's something we > can/should > > > fix > > > > >> in > > > > >>>> Calcite itself. > > > > >>>> > > > > >>>> Can you share what you're seeing, Edmon? > > > > >>>> > > > > >>>> > > > > >>>> On 2/8/18 1:20 AM, Malcolm Taylor wrote: > > > > >>>> > > > > >>>>> This worked for me: > > > > >>>>> 1) fork the calcite repository on github > > > > >>>>> 2) clone your fork > > > > >>>>> 3) mvn -version > > > > >>>>> (make sure you have Maven 3.5.2, if not then upgrade) > > > > >>>>> 4) mvn eclipse:eclipse > > > > >>>>> 5) start eclipse, Import existing projects into workspace > > > > >>>>> > > > > >>>>> On 8 February 2018 at 02:20, Edmon Begoli <[email protected]> > > > wrote: > > > > >>>>> > > > > >>>>> Does anyone have instructions how to setup Eclipse for Calcite > > > > >>>>>> development? > > > > >>>>>> > > > > >>>>>> I would like to document that for CALCITE-2172 > > > > >>>>>> <https://issues.apache.org/jira/browse/CALCITE-2172> while I > am > > > at > > > > >> it. > > > > >>>>>> > > > > >>>>>> > > > > >>>>> > > > > >>> > > > > >> > > > > > > > > > > > > > >
