Downloaded sources from [1] and ran unit tests. All unit tests are passed on my machine with the total time 06:11 min (JDK 8, Linux). Checked that JDK 7 is deprecated. Checked Drill with Calcite 1.16.0 (added several Drill-specific commits on top of [2]). All Drill unit and regression tests are passed successfully, no regressions were found.
+1 (non-binding) [1] https://dist.apache.org/repos/dist/dev/calcite/apache-calcite-1.16.0-rc0 [2] http://git-wip-us.apache.org/repos/asf/calcite/commit/ 96b73060fdc77db9c13e40f6f82f374bb41d12c8 2018-03-14 21:04 GMT+02:00 Julian Hyde <[email protected]>: > Yes, you'll need to update the release instructions (howto.md) and the > list of algorithms in pom.xml. I did this recently in avatica: > https://github.com/apache/calcite-avatica/commit/ > c115d418cb638d4a11e38249fdaab6745748d362. > I see that the downloads page https://calcite.apache.org/downloads/ > already offers the .sha256 as the checksum, and ignores the .md5 file. > > The presence of the .md5 is OK for this release because > http://www.apache.org/dev/release-distribution.html#sigs-and-sums only > says "SHOULD NOT supply a MD5 checksum" not "MUST NOT". > > Downloaded; checked digests, NOTICE, LICENSE; built under JDK 8 on Linux. > > +1 > > Julian > > > On Wed, Mar 14, 2018 at 1:57 AM, Jesus Camacho Rodriguez > <[email protected]> wrote: > > Hi Julian, > > > > Thanks for pointing that out. Indeed I had copied last vote email. The > md5 are generated following the release instructions, hence those need to > be updated too. Since sha256 is included in the vote email, I think it is > sufficient to ask to validate against that hash instead of restarting the > vote? If vote passes, I will update the instructions when I merge the > branch into master. > > > > -Jesús > > > > > > On 3/14/18, 1:23 AM, "Julian Hyde" <[email protected]> wrote: > > > > Following https://issues.apache.org/jira/browse/CALCITE-1972 < > https://issues.apache.org/jira/browse/CALCITE-1972> I thought we were > only going to generate .sha256, not .md5 anymore. (I did this for > avatica-1.11 recently, apparently not for calcite1-15 when I was RM.) > > > > > > > On Mar 14, 2018, at 1:14 AM, Jesus Camacho Rodriguez < > [email protected]> wrote: > > > > > > Hi all, > > > > > > I have created a build for Apache Calcite 1.16.0, release > candidate 0. > > > > > > Thanks to everyone who has contributed to this release. > > > You can read the release notes here: > > > https://github.com/apache/calcite/blob/branch-1.16/site/ > _docs/history.md > > > > > > The commit to be voted upon: > > > http://git-wip-us.apache.org/repos/asf/calcite/commit/ > 96b73060fdc77db9c13e40f6f82f374bb41d12c8 > > > > > > Its hash is 96b73060fdc77db9c13e40f6f82f374bb41d12c8. > > > > > > The artifacts to be voted on are located here: > > > https://dist.apache.org/repos/dist/dev/calcite/apache- > calcite-1.16.0-rc0 > > > > > > The hashes of the artifacts are as follows: > > > src.tar.gz.md5 4849ebf6a1968111aca7c86ace193a9c > > > src.tar.gz.sha256 92d8c18cdcda81e81ddbd53bab92ac > dd53b021bc0d452a0b8c21f51ecb1dfcdf > > > src.zip.md5 0da85ae5de97a0b5d989c140e5d41044 > > > src.zip.sha256 d096286a00f2cee588485f4bcb9d05 > 1eaff4ed2e4874084464ec76eea257a79e > > > > > > A staged Maven repository is available for review at: > > > https://repository.apache.org/content/repositories/ > orgapachecalcite-1042 > > > > > > Release artifacts are signed with the following key: > > > https://people.apache.org/keys/committer/jcamacho.asc > > > > > > Please vote on releasing this package as Apache Calcite 1.16.0. > > > > > > The vote is open for the next 72 hours and passes if a majority of > > > at least three +1 PMC votes are cast. > > > > > > [ ] +1 Release this package as Apache Calcite 1.16.0 > > > [ ] 0 I don't feel strongly about it, but I'm okay with the > release > > > [ ] -1 Do not release this package because... > > > > > > > > > Here is my vote: > > > > > > +1 (binding) > > > > > > Jesús > > > > > > > > > > > > > > > > > > -- Kind regards, Volodymyr Vysotskyi
