chenBright opened a new pull request, #3760:
URL: https://github.com/apache/brpc/pull/3760

   ### What problem does this PR solve?
   
   Issue Number: resolve 
   
   Problem Summary:
   
   `BthreadTest.test_span` uses a static counter to index a four-element array 
of span IDs. The first run consumes all four entries. When Google Test repeats 
the test in the same process, the first span created on the second run reads 
past the end of the array.
   
   ### What is changed and the side effects?
   
   Changed:
   
   - Replace the static counter and ID array with a span tree local to each 
test run.
   - Check that each child and grandchild receives its expected span, 
regardless of which branch runs first.
   - Restore the original span callbacks and the calling thread's parent span 
when the test exits, including after a failed assertion.
   
   Side effects:
   - Performance effects:
   
   - Breaking backward compatibility: 
   
   ---
   ### Check List:
   - Please make sure your changes are compilable.
   - When providing us with a new feature, it is best to add related tests.
   - Please follow [Contributor Covenant Code of 
Conduct](https://github.com/apache/brpc/blob/master/CODE_OF_CONDUCT.md).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to