randomkang commented on code in PR #3144: URL: https://github.com/apache/brpc/pull/3144#discussion_r4513189983
########## src/butil/config.h.in: ########## @@ -26,6 +26,12 @@ #endif #define BRPC_WITH_FLATBUFFERS @WITH_FLATBUFFERS_VAL@ +// Defined to 1 when brpc is built with GPU Direct RDMA support. +#ifdef BRPC_WITH_GDR +#undef BRPC_WITH_GDR +#endif +#cmakedefine BRPC_WITH_GDR @WITH_GDR_VAL@ Review Comment: okļ¼just as BRPC_WITH_RDMA, the definition of BRPC_WITH_GDR should not appear here and we have removed it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
