darion-yaphet opened a new pull request, #3413:
URL: https://github.com/apache/brpc/pull/3413
### What problem does this PR solve?
Issue Number: resolve
Problem Summary:
The `/vars` HTML page rendered each bvar as a plain `<p>` line (`name :
value`), so names and values were hard to scan when lengths varied. Expandable
flot chart
blocks were also mixed into the same flow, which made the layout less
structured.
### What is changed and the side effects?
Changed:
- Render `/vars` HTML output as a `gridtable` with `Name` / `Value`
columns.
- Put each variable in a `<tr class="variable|nonplot-variable">` row.
- Move expandable flot charts into a dedicated `<tr class="detail-row">`
under the corresponding variable.
- Keep non-HTML (`curl` / plain text) `/vars` output unchanged.
Side effects:
- Performance effects: None expected. Only the HTML presentation path of
`/vars` is changed.
- Breaking backward compatibility: No. Plain-text `/vars` responses are
unchanged; only browser HTML layout is updated.
---
### Check List:
- Please make sure your changes are compilable.
- When providing us with a new feature, it is best to add related tests.
- Please follow [Contributor Covenant Code of
Conduct](https://github.com/apache/brpc/blob/master/CODE_OF_CONDUCT.md).
<img width="2356" height="1170" alt="image"
src="https://github.com/user-attachments/assets/ea21451b-c1a1-44f1-aee8-44ca677b3650";
/>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
