Copilot commented on code in PR #3400:
URL: https://github.com/apache/brpc/pull/3400#discussion_r3651535614
##########
src/bvar/variable.h:
##########
@@ -39,16 +39,6 @@ namespace bvar {
DECLARE_bool(save_series);
-#define COMMON_VARIABLE_CONSTRUCTOR(TypeName)
\
- TypeName() = default;
\
- TypeName(const butil::StringPiece& name) {
\
- this->expose(name);
\
- }
\
- TypeName(const butil::StringPiece& prefix, const butil::StringPiece& name)
{ \
- this->expose_as(prefix, name);
\
- }
\
-
-
// Bitwise masks of displayable targets
Review Comment:
`src/` headers are installed as part of the public include set (CMake copies
`src/` into `output/include/` and installs it). Removing
`COMMON_VARIABLE_CONSTRUCTOR` from `bvar/variable.h` is therefore a
source-compatibility break for any downstream code that relied on this macro.
Consider keeping a deprecated compatibility definition (even if the project no
longer uses it internally) for at least one release cycle, or explicitly
documenting this breaking change in release notes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
