chenBright opened a new pull request, #3373: URL: https://github.com/apache/brpc/pull/3373
### What problem does this PR solve? Issue Number: introduced by PR #2938 . Problem Summary: `Controller::HandleStreamConnection` called `s->SetHostSocket()` on the first stream inside the extra-stream loop. When an extra stream carried no downstream data (nothing triggered `Stream::OnReceived()` to set `host_socket` for it), `Stream::SetConnected()` hit `CHECK(_host_socket != NULL)`. ### What is changed and the side effects? Changed: Set `host_socket` on the extra stream itself, matching the server-side logic in baidu_rpc_protocol. Side effects: - Performance effects: - Breaking backward compatibility: --- ### Check List: - Please make sure your changes are compilable. - When providing us with a new feature, it is best to add related tests. - Please follow [Contributor Covenant Code of Conduct](https://github.com/apache/brpc/blob/master/CODE_OF_CONDUCT.md). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
