Felix-Gong commented on code in PR #3346: URL: https://github.com/apache/brpc/pull/3346#discussion_r3417846787
########## test/sstream_workaround.h: ########## @@ -18,16 +18,12 @@ #ifndef BUTIL_TEST_SSTREAM_WORKAROUND #define BUTIL_TEST_SSTREAM_WORKAROUND -// defining private as public makes it fail to compile sstream with gcc5.x like this: -// "error: ‘struct std::__cxx11::basic_stringbuf<_CharT, _Traits, _Alloc>:: -// __xfer_bufptrs’ redeclared with different access" - -#ifdef private -# undef private -# include <sstream> -# define private public -#else -# include <sstream> -#endif +// Previously, tests used -Dprivate=public to access private members. Review Comment: Done. Deleted the file since it's no longer referenced after switching to -fno-access-control. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
