rajvarun77 commented on PR #3310: URL: https://github.com/apache/brpc/pull/3310#issuecomment-4676081483
@chenBright Done — moved the MySQL auth unittests out of `test/mysql/` into `test/`. As you noted, no build-script changes were needed: the existing `brpc_*_unittest` glob in `test/Makefile`, `test/CMakeLists.txt`, and `test/BUILD.bazel` picks them up automatically, and `test/run_tests.sh` is back to its master version as well. CI is green — all three auth unittests run and pass in the make/cmake unittest jobs: - `brpc_mysql_auth_handshake_unittest` — 28 passed - `brpc_mysql_auth_packet_unittest` — 27 passed - `brpc_mysql_auth_scramble_unittest` — 35 passed Thanks for the review! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
